From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Maso Huang <maso.huang@mediatek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/2] ASoC: mediatek: mt7986: remove redundant remove function
Date: Mon, 23 Oct 2023 13:07:02 +0200 [thread overview]
Message-ID: <07af235a-c6d5-4d8d-9b44-ff7157e2a80c@collabora.com> (raw)
In-Reply-To: <20231023095453.4860-2-maso.huang@mediatek.com>
Il 23/10/23 11:54, Maso Huang ha scritto:
> Remove redundant remove function of mt7986-wm8960.
>
> Signed-off-by: Maso Huang <maso.huang@mediatek.com>
You're doing more than what you're advertising; you are:
1. Dropping the remove callback; and
2. Removing the mt7986_wm8960_priv structure
You can do that in one single commit if you really want to, but you have to
use the appropriate commit title and description, saying exactly what you're doing.
Regards,
Angelo
next prev parent reply other threads:[~2023-10-23 11:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 9:54 [PATCH 0/2] ASoC: mediatek: Remove redundant code and add sample rate checker of MT7986 SoC Maso Huang
2023-10-23 9:54 ` [PATCH 1/2] ASoC: mediatek: mt7986: remove redundant remove function Maso Huang
2023-10-23 11:07 ` AngeloGioacchino Del Regno [this message]
2023-10-24 2:28 ` Maso Huang (黃加竹)
2023-10-23 9:54 ` [PATCH 2/2] ASoC: mediatek: mt7986: add sample rate checker Maso Huang
2023-10-23 11:07 ` AngeloGioacchino Del Regno
2023-10-24 2:27 ` Maso Huang (黃加竹)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07af235a-c6d5-4d8d-9b44-ff7157e2a80c@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maso.huang@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome