mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Maso Huang (黃加竹)" <Maso.Huang@mediatek.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mediatek@lists.infradead.org" 
	<linux-mediatek@lists.infradead.org>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"tiwai@suse.com" <tiwai@suse.com>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"perex@perex.cz" <perex@perex.cz>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"angelogioacchino.delregno@collabora.com" 
	<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH 1/2] ASoC: mediatek: mt7986: remove redundant remove function
Date: Tue, 24 Oct 2023 02:28:57 +0000	[thread overview]
Message-ID: <b5fa38585cef3739b0672cb73c71beed2d3f2cf5.camel@mediatek.com> (raw)
In-Reply-To: <07af235a-c6d5-4d8d-9b44-ff7157e2a80c@collabora.com>

On Mon, 2023-10-23 at 13:07 +0200, AngeloGioacchino Del Regno wrote:
> Il 23/10/23 11:54, Maso Huang ha scritto:
> > Remove redundant remove function of mt7986-wm8960.
> > 
> > Signed-off-by: Maso Huang <maso.huang@mediatek.com>
> 
> You're doing more than what you're advertising; you are:
> 
> 1. Dropping the remove callback; and
> 2. Removing the mt7986_wm8960_priv structure
> 
> You can do that in one single commit if you really want to, but you
> have to
> use the appropriate commit title and description, saying exactly what
> you're doing.
> 
> Regards,
> Angelo
> 

Hi Angelo,

Thanks for your review!
I'll devide into two with appropriate title and description in v2.

Best regards,
Maso

  reply	other threads:[~2023-10-24  2:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-23  9:54 [PATCH 0/2] ASoC: mediatek: Remove redundant code and add sample rate checker of MT7986 SoC Maso Huang
2023-10-23  9:54 ` [PATCH 1/2] ASoC: mediatek: mt7986: remove redundant remove function Maso Huang
2023-10-23 11:07   ` AngeloGioacchino Del Regno
2023-10-24  2:28     ` Maso Huang (黃加竹) [this message]
2023-10-23  9:54 ` [PATCH 2/2] ASoC: mediatek: mt7986: add sample rate checker Maso Huang
2023-10-23 11:07   ` AngeloGioacchino Del Regno
2023-10-24  2:27     ` Maso Huang (黃加竹)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5fa38585cef3739b0672cb73c71beed2d3f2cf5.camel@mediatek.com \
    --to=maso.huang@mediatek.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome