From: Elson Serrao <elson.serrao@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 8/8] arm64: dts: qcom: kodiak: Desribe EUD UTMI routing and connector mapping
Date: Tue, 22 Sep 2026 21:40:39 -0700 [thread overview]
Message-ID: <07e73495-ac4e-42a6-b5a3-5eb11021d7fb@oss.qualcomm.com> (raw)
In-Reply-To: <8daa32e6-f140-44d1-a2d2-c475d8a5959c@oss.qualcomm.com>
On 9/21/2026 4:37 AM, Konrad Dybcio wrote:
> On 9/13/26 12:53 AM, Elson Serrao wrote:
>> The existing EUD description uses a legacy single-path representation
>> that assumes uniform UTMI routing. This was sufficient for minimal
>> configurations where the USB port operated only in device mode and role
>> switching was not considered.
>>
>> Update the description to explicitly model the topology using eud path
>> child node and add a role-switch declaration to reflect role-dependent
>> UTMI routing. Also on this SoC, the EUD hardware intercepts only the
>> primary UTMI path. So remove the USB endpoint mapping to the secondary
>> controller and associate it with the primary controller.
>>
>> With the intermediate EUD node now in place, update the Kodiak board
>> descriptions to map the USB connector endpoint to the EUD instead of
>> directly to the USB controller, reflecting the intended hardware
>> topology. Enable the EUD by default now that the complete topology is
>> described.
>>
>> Signed-off-by: Elson Serrao <elson.serrao@oss.qualcomm.com>
>> ---
>
> [...]
>
>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
>> index f41ad446a39e..b1f1ff6b99e6 100644
>> --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
>> @@ -98,7 +98,7 @@ port@0 {
>> reg = <0>;
>>
>> pmic_glink_hs_in: endpoint {
>> - remote-endpoint = <&usb_1_dwc3_hs>;
>> + remote-endpoint = <&eud_con>;
>> };
>> };
>>
>> @@ -1530,10 +1530,6 @@ &usb_1 {
>> status = "okay";
>> };
>>
>> -&usb_1_dwc3_hs {
>> - remote-endpoint = <&pmic_glink_hs_in>;
>> -};
>> -
>> &usb_1_hsphy {
>> vdda-pll-supply = <&vreg_l10c>;
>> vdda18-supply = <&vreg_l1c>;
>> @@ -1573,3 +1569,7 @@ &wifi {
>> qcom,calibration-variant = "Fairphone_5";
>> status = "okay";
>> };
>> +
>> +&eud_con {
>> + remote-endpoint = <&pmic_glink_hs_in>;
>> +};
>
> Label references should be sorted alphabetically within a file,
> there may be slight deviations because the tooling to enforce
> that is still under development, but let's try to not add more
>
Ack. I will update this in v9
Thanks
Elson
prev parent reply other threads:[~2026-09-23 4:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-12 22:52 [PATCH v8 0/8] Improve Qualcomm EUD driver and platform support Elson Serrao
2026-09-12 22:52 ` [PATCH v8 1/8] dt-bindings: soc: qcom: eud: Add per-path child nodes for UTMI routing Elson Serrao
2026-09-12 22:52 ` [PATCH v8 2/8] usb: misc: qcom_eud: add sysfs attribute for port selection Elson Serrao
2026-09-12 22:52 ` [PATCH v8 3/8] usb: misc: qcom_eud: add per-path High-Speed PHY control Elson Serrao
2026-09-12 22:52 ` [PATCH v8 4/8] usb: misc: qcom_eud: add per-path role switch support Elson Serrao
2026-09-12 22:52 ` [PATCH v8 5/8] usb: misc: qcom_eud: improve enable_store API Elson Serrao
2026-09-12 22:52 ` [PATCH v8 6/8] usb: misc: qcom_eud: add role-based EUD control Elson Serrao
2026-09-12 22:53 ` [PATCH v8 7/8] usb: misc: qcom_eud: fix virtual attach/detach event handling Elson Serrao
2026-09-12 22:53 ` [PATCH v8 8/8] arm64: dts: qcom: kodiak: Desribe EUD UTMI routing and connector mapping Elson Serrao
2026-09-21 11:37 ` Konrad Dybcio
2026-09-23 4:40 ` Elson Serrao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07e73495-ac4e-42a6-b5a3-5eb11021d7fb@oss.qualcomm.com \
--to=elson.serrao@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®