Re: [PATCH v2 2/3] sched/fair: Ignore isolated cpus in update_numa_stat

[Chuyi Zhou <zhouchuyi@bytedance.com>]

Hello Madadi Vineeth Reddy,

在 2025/1/6 02:52, Madadi Vineeth Reddy 写道:
> On 03/01/25 12:29, Chuyi Zhou wrote:
>> Now update_numa_stats() iterates each cpu in a node to gather load
>> information for the node and attempts to find the idle cpu as a candidate
>> best_cpu within the node.
>>
>> In update_numa_stats() we should take into account the scheduling domain.
>> This is because the "isolcpus" kernel command line option and cpuset iso-
>> late partitions can remove CPUs from load balance. Similar to task wakeup
>> and periodic load balancing, we should not involve isolated CPUs in NUMA
>> balancing. When gathering load information for nodes, we need to ignore the
>> load of isolated CPUs. This change also avoids selecting an isolated CPU
>> as the idle_cpu.
> 
> If possible, would you be able to share any performance metrics or benchmarks
> that demonstrate the impact of this patch on NUMA balancing or CPU migration
> efficiency?
> 
> Thanks,
> Madadi Vineeth Reddy
> 

This change will not alter the default behavior of NUMA balancing unless 
we enables both NUMA balancing and isolated CPUs features. Therefore, 
under normal default conditions, there should be no performance 
regression. On the other hand, involving isolated CPUs in NUMA balancing 
or load balancing is inappropriate, and this is the issue that this 
patch aims to fix.

It might be worth setting up a test scenario for cases where NUMA 
balancing and isolated CPUs are both enabled. Perhaps this testing will 
be done later on.

Thanks.