From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "jmattson@google.com" <jmattson@google.com>,
"Gao, Chao" <chao.gao@intel.com>,
"seanjc@google.com" <seanjc@google.com>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"Annapurve, Vishal" <vannapurve@google.com>,
"Chatre, Reinette" <reinette.chatre@intel.com>,
"Li, Xiaoyao" <xiaoyao.li@intel.com>,
"Aktas, Erdem" <erdemaktas@google.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"mlevitsk@redhat.com" <mlevitsk@redhat.com>,
"Yamahata, Isaku" <isaku.yamahata@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V4 1/4] KVM: x86: hyper-v: Calculate APIC bus frequency for Hyper-V
Date: Tue, 16 Apr 2024 17:07:58 +0000 [thread overview]
Message-ID: <081f049fd8601ee81d9883797acafa006e7991c4.camel@intel.com> (raw)
In-Reply-To: <d815921fff4c616c8b05bff0fb9377a171c8633b.1711035400.git.reinette.chatre@intel.com>
On Thu, 2024-03-21 at 09:37 -0700, Reinette Chatre wrote:
> From: Isaku Yamahata <isaku.yamahata@intel.com>
>
> Remove APIC_BUS_FREQUENCY and calculate it based on nanoseconds per APIC
> bus cycle. APIC_BUS_FREQUENCY is used only for HV_X64_MSR_APIC_FREQUENCY.
> The MSR is not frequently read, calculate it every time.
>
> There are two constants related to the APIC bus frequency:
> APIC_BUS_FREQUENCY and APIC_BUS_CYCLE_NS.
> Only one value is required because one can be calculated from the other:
> APIC_BUS_CYCLES_NS = 1000 * 1000 * 1000 / APIC_BUS_FREQUENCY.
>
> Remove APIC_BUS_FREQUENCY and instead calculate it when needed.
> This prepares for support of configurable APIC bus frequency by
> requiring to change only a single variable.
>
> Suggested-by: Maxim Levitsky <maximlevitsky@gmail.com>
> Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
> Reviewed-by: Maxim Levitsky <maximlevitsky@gmail.com>
> Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>
> [reinette: rework changelog]
> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Reviewed-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
next prev parent reply other threads:[~2024-04-16 17:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 16:37 [PATCH V4 0/4] KVM: x86: Make bus clock frequency for vAPIC timer configurable Reinette Chatre
2024-03-21 16:37 ` [PATCH V4 1/4] KVM: x86: hyper-v: Calculate APIC bus frequency for Hyper-V Reinette Chatre
2024-04-16 17:07 ` Edgecombe, Rick P [this message]
2024-03-21 16:37 ` [PATCH V4 2/4] KVM: x86: Make nsec per APIC bus cycle a VM variable Reinette Chatre
2024-04-16 17:08 ` Edgecombe, Rick P
2024-03-21 16:37 ` [PATCH V4 3/4] KVM: x86: Add a capability to configure bus frequency for APIC timer Reinette Chatre
2024-04-16 17:08 ` Edgecombe, Rick P
2024-04-16 21:28 ` Reinette Chatre
2024-04-17 3:37 ` Xiaoyao Li
2024-03-21 16:37 ` [PATCH V4 4/4] KVM: selftests: Add test for configure of x86 APIC bus frequency Reinette Chatre
2024-04-16 17:09 ` [PATCH V4 0/4] KVM: x86: Make bus clock frequency for vAPIC timer configurable Edgecombe, Rick P
2024-04-24 16:13 ` Sean Christopherson
2024-04-24 16:38 ` Edgecombe, Rick P
2024-04-24 17:23 ` Sean Christopherson
2024-04-24 18:10 ` Edgecombe, Rick P
2024-04-24 19:57 ` Sean Christopherson
2024-04-24 21:20 ` Reinette Chatre
2024-04-25 16:17 ` Sean Christopherson
2024-04-25 16:39 ` Reinette Chatre
2024-04-24 21:07 ` Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=081f049fd8601ee81d9883797acafa006e7991c4.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=chao.gao@intel.com \
--cc=erdemaktas@google.com \
--cc=isaku.yamahata@intel.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=seanjc@google.com \
--cc=vannapurve@google.com \
--cc=vkuznets@redhat.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®