* [PATCH] drm/panel: samsung-s6d7aa0: Add MODULE_DEVICE_TABLE
@ 2023-08-02 6:41 Nikita Travkin
2023-08-02 8:01 ` Neil Armstrong
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Nikita Travkin @ 2023-08-02 6:41 UTC (permalink / raw)
To: Artur Weber, Neil Armstrong, Sam Ravnborg, David Airlie, Daniel Vetter
Cc: dri-devel, linux-kernel, Nikita Travkin
The driver can be built as a module, however the lack of the
MODULE_DEVICE_TABLE macro prevents it from being automatically probed
from the DT in such case.
Add the missed macro to make sure the module can load automatically.
Fixes: 6810bb390282 ("drm/panel: Add Samsung S6D7AA0 panel controller driver")
Signed-off-by: Nikita Travkin <nikita@trvn.ru>
---
drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
index 0583360b1280..ea5a85779382 100644
--- a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
+++ b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
@@ -567,6 +567,7 @@ static const struct of_device_id s6d7aa0_of_match[] = {
},
{ /* sentinel */ }
};
+MODULE_DEVICE_TABLE(of, s6d7aa0_of_match);
static struct mipi_dsi_driver s6d7aa0_driver = {
.probe = s6d7aa0_probe,
---
base-commit: 626c67169f9972fffcdf3bc3864de421f162ebf5
change-id: 20230802-gt5-panel-dtable-d9d6ca407f26
Best regards,
--
Nikita Travkin <nikita@trvn.ru>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/panel: samsung-s6d7aa0: Add MODULE_DEVICE_TABLE
2023-08-02 6:41 [PATCH] drm/panel: samsung-s6d7aa0: Add MODULE_DEVICE_TABLE Nikita Travkin
@ 2023-08-02 8:01 ` Neil Armstrong
2023-08-02 8:38 ` Artur Weber
2023-08-02 8:58 ` Neil Armstrong
2 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2023-08-02 8:01 UTC (permalink / raw)
To: Nikita Travkin, Artur Weber, Sam Ravnborg, David Airlie, Daniel Vetter
Cc: dri-devel, linux-kernel
On 02/08/2023 08:41, Nikita Travkin wrote:
> The driver can be built as a module, however the lack of the
> MODULE_DEVICE_TABLE macro prevents it from being automatically probed
> from the DT in such case.
>
> Add the missed macro to make sure the module can load automatically.
>
> Fixes: 6810bb390282 ("drm/panel: Add Samsung S6D7AA0 panel controller driver")
> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
> ---
> drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
> index 0583360b1280..ea5a85779382 100644
> --- a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
> +++ b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
> @@ -567,6 +567,7 @@ static const struct of_device_id s6d7aa0_of_match[] = {
> },
> { /* sentinel */ }
> };
> +MODULE_DEVICE_TABLE(of, s6d7aa0_of_match);
>
> static struct mipi_dsi_driver s6d7aa0_driver = {
> .probe = s6d7aa0_probe,
>
> ---
> base-commit: 626c67169f9972fffcdf3bc3864de421f162ebf5
> change-id: 20230802-gt5-panel-dtable-d9d6ca407f26
>
> Best regards,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/panel: samsung-s6d7aa0: Add MODULE_DEVICE_TABLE
2023-08-02 6:41 [PATCH] drm/panel: samsung-s6d7aa0: Add MODULE_DEVICE_TABLE Nikita Travkin
2023-08-02 8:01 ` Neil Armstrong
@ 2023-08-02 8:38 ` Artur Weber
2023-08-02 8:58 ` Neil Armstrong
2 siblings, 0 replies; 4+ messages in thread
From: Artur Weber @ 2023-08-02 8:38 UTC (permalink / raw)
To: Nikita Travkin, Neil Armstrong, Sam Ravnborg, David Airlie,
Daniel Vetter
Cc: dri-devel, linux-kernel
On 2.08.2023 08:41, Nikita Travkin wrote:
> The driver can be built as a module, however the lack of the
> MODULE_DEVICE_TABLE macro prevents it from being automatically probed
> from the DT in such case.
>
> Add the missed macro to make sure the module can load automatically.
>
> Fixes: 6810bb390282 ("drm/panel: Add Samsung S6D7AA0 panel controller driver")
> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
> ---
> drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Artur Weber <aweber.kernel@gmail.com>
Best regards
Artur
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/panel: samsung-s6d7aa0: Add MODULE_DEVICE_TABLE
2023-08-02 6:41 [PATCH] drm/panel: samsung-s6d7aa0: Add MODULE_DEVICE_TABLE Nikita Travkin
2023-08-02 8:01 ` Neil Armstrong
2023-08-02 8:38 ` Artur Weber
@ 2023-08-02 8:58 ` Neil Armstrong
2 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2023-08-02 8:58 UTC (permalink / raw)
To: Artur Weber, Sam Ravnborg, David Airlie, Daniel Vetter, Nikita Travkin
Cc: dri-devel, linux-kernel
Hi,
On Wed, 02 Aug 2023 11:41:22 +0500, Nikita Travkin wrote:
> The driver can be built as a module, however the lack of the
> MODULE_DEVICE_TABLE macro prevents it from being automatically probed
> from the DT in such case.
>
> Add the missed macro to make sure the module can load automatically.
>
>
> [...]
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes)
[1/1] drm/panel: samsung-s6d7aa0: Add MODULE_DEVICE_TABLE
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=c71b7aa8619a0c9700132d0733e33999fb614339
--
Neil
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-02 8:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-02 6:41 [PATCH] drm/panel: samsung-s6d7aa0: Add MODULE_DEVICE_TABLE Nikita Travkin
2023-08-02 8:01 ` Neil Armstrong
2023-08-02 8:38 ` Artur Weber
2023-08-02 8:58 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®