From: Dmitry Osipenko <digetx@gmail.com>
To: "Wang, Jiada" <jiada_wang@mentor.com>,
dmitry.torokhov@gmail.com, robh+dt@kernel.org,
thierry.reding@gmail.com, jonathanh@nvidia.com
Cc: nick@shmanahar.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
erosca@de.adit-jv.com, andrew_gabbasov@mentor.com
Subject: Re: [PATCH v3 0/3] implement I2C retries for mXT1368
Date: Wed, 28 Oct 2020 00:52:37 +0300 [thread overview]
Message-ID: <082b9b1c-5f89-7deb-728b-3de4339ac131@gmail.com> (raw)
In-Reply-To: <653c24a4-704a-4d65-2622-49c55a82c901@mentor.com>
21.10.2020 04:14, Wang, Jiada пишет:
> Hello Dmitry and all
>
> Kind reminder on this patch-set
Hello Jiada,
Thinking a bit more about these patches, I'm coming back to the variant
with the atmel,wakeup-method property. There are three possible wake-up
variants for mXT1368:
- NONE
- GPIO
- I2C-SCL
and this series covers only the I2C-SCL.
I was also skimming through datasheets of other maxtouch touchscreens
and noticed that the retries aren't unique to mXT1368. For example
mXT3432 controller also needs exactly the same retrying logic.
Hence I think it should be better if we could generalize the
wakeup-method in the device-tree. What do you think?
prev parent reply other threads:[~2020-10-27 21:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 15:12 Jiada Wang
2020-09-30 15:12 ` [PATCH v3 1/3] dt-bindings: input: atmel: add compatible for mXT1386 Jiada Wang
2020-09-30 15:12 ` [PATCH v3 2/3] Input: atmel_mxt_ts - implement I2C retries for mXT1368 Jiada Wang
2020-09-30 15:12 ` [PATCH v3 3/3] ARM: tegra: add mXT1386 compatible Jiada Wang
2020-10-21 1:14 ` [PATCH v3 0/3] implement I2C retries for mXT1368 Wang, Jiada
2020-10-27 21:52 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=082b9b1c-5f89-7deb-728b-3de4339ac131@gmail.com \
--to=digetx@gmail.com \
--cc=andrew_gabbasov@mentor.com \
--cc=dmitry.torokhov@gmail.com \
--cc=erosca@de.adit-jv.com \
--cc=jiada_wang@mentor.com \
--cc=jonathanh@nvidia.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nick@shmanahar.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®