From: "Wang, Jiada" <jiada_wang@mentor.com>
To: <dmitry.torokhov@gmail.com>, <robh+dt@kernel.org>,
<thierry.reding@gmail.com>, <digetx@gmail.com>,
<jonathanh@nvidia.com>
Cc: <nick@shmanahar.org>, <linux-input@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<erosca@de.adit-jv.com>, <andrew_gabbasov@mentor.com>
Subject: Re: [PATCH v3 0/3] implement I2C retries for mXT1368
Date: Wed, 21 Oct 2020 10:14:29 +0900 [thread overview]
Message-ID: <653c24a4-704a-4d65-2622-49c55a82c901@mentor.com> (raw)
In-Reply-To: <20200930151259.18119-1-jiada_wang@mentor.com>
Hello Dmitry and all
Kind reminder on this patch-set
Thanks,
Jiada
On 2020/10/01 0:12, Jiada Wang wrote:
> According to datasheet, mXT1386 chip has a WAKE line, it is used
> to wake the chip up from deep sleep mode before communicating with
> it via the I2C-compatible interface.
>
> if the WAKE line is connected to a GPIO line, the line must be
> asserted 25 ms before the host attempts to communicate with the
> mXT1386.
> If the WAKE line is connected to the SCL pin, the mXT1386 will send
> a NACK on the first attempt to address it, the host must then retry
> 25 ms later.
>
> This patch adds compatible string "atmel,mXT1386" for mXT1386 controller,
> when I2C transfer on mXT1386 fails, retry the transfer once after a
> 25 ms sleep.
>
>
> Jiada Wang (3):
> dt-bindings: input: atmel: add compatible for mXT1386
> Input: atmel_mxt_ts - implement I2C retries for mXT1368
> ARM: tegra: add mXT1386 compatible
>
> ---
> v3:
> change compatible string to lowercase
>
> v2:
> add bool retry_i2c_transfers to struct mxt_data,
> to indicate whether retry is needed when i2c transfer fails
>
> v1: initial version
> ---
> .../bindings/input/atmel,maxtouch.txt | 1 +
> .../boot/dts/tegra20-acer-a500-picasso.dts | 2 +-
> drivers/input/touchscreen/atmel_mxt_ts.c | 62 +++++++++++++++----
> 3 files changed, 52 insertions(+), 13 deletions(-)
>
next prev parent reply other threads:[~2020-10-21 1:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 15:12 Jiada Wang
2020-09-30 15:12 ` [PATCH v3 1/3] dt-bindings: input: atmel: add compatible for mXT1386 Jiada Wang
2020-09-30 15:12 ` [PATCH v3 2/3] Input: atmel_mxt_ts - implement I2C retries for mXT1368 Jiada Wang
2020-09-30 15:12 ` [PATCH v3 3/3] ARM: tegra: add mXT1386 compatible Jiada Wang
2020-10-21 1:14 ` Wang, Jiada [this message]
2020-10-27 21:52 ` [PATCH v3 0/3] implement I2C retries for mXT1368 Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=653c24a4-704a-4d65-2622-49c55a82c901@mentor.com \
--to=jiada_wang@mentor.com \
--cc=andrew_gabbasov@mentor.com \
--cc=digetx@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=erosca@de.adit-jv.com \
--cc=jonathanh@nvidia.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nick@shmanahar.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®