From: Hayes Wang <hayeswang@realtek.com>
To: Heiner Kallweit <hkallweit1@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: nic_swsd <nic_swsd@realtek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next] r8152: modify rtl8152_set_speed function
Date: Tue, 3 Sep 2019 07:36:54 +0000 [thread overview]
Message-ID: <0835B3720019904CB8F7AA43166CEEB2F18DADA1@RTITMBSVM03.realtek.com.tw> (raw)
In-Reply-To: <32d490ae-70af-ba86-93de-be342a2a7e39@gmail.com>
Heiner Kallweit [mailto:hkallweit1@gmail.com]
> Sent: Tuesday, September 03, 2019 3:13 PM
[...]
> > Some of our chips support the feature of UPS. When satisfying certain
> > condition, the hw would recover the settings of speed. Therefore, I have
> > to record the settings of the speed, and set them to hw.
> >
> Not knowing the UPS feature in detail:
> In net-next I changed the software "PHY speed-down" implementation to
> be more generic. It stores the old advertised settings in a new
> phy_device member adv_old, and restores them in phy_speed_up().
> Maybe what you need is similar.
It is a feature about power saving. When some conditions are
satisfied, the power of PHY would be cut. And the hw would
restore the PHY settings including the speed automatically,
when leaving power saving mode.
Best Regards,
Hayes
next prev parent reply other threads:[~2019-09-03 7:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 11:52 Hayes Wang
2019-09-02 18:36 ` Heiner Kallweit
2019-09-03 3:16 ` Hayes Wang
2019-09-03 6:13 ` Heiner Kallweit
2019-09-03 6:36 ` Hayes Wang
2019-09-03 6:44 ` Heiner Kallweit
2019-09-03 6:55 ` Hayes Wang
2019-09-03 7:12 ` Heiner Kallweit
2019-09-03 7:36 ` Hayes Wang [this message]
2019-09-04 22:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0835B3720019904CB8F7AA43166CEEB2F18DADA1@RTITMBSVM03.realtek.com.tw \
--to=hayeswang@realtek.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®