From: Heiner Kallweit <hkallweit1@gmail.com>
To: Hayes Wang <hayeswang@realtek.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: nic_swsd <nic_swsd@realtek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] r8152: modify rtl8152_set_speed function
Date: Tue, 3 Sep 2019 08:13:42 +0200 [thread overview]
Message-ID: <aa9513ff-3cef-4b9f-ecbd-1310660a911c@gmail.com> (raw)
In-Reply-To: <0835B3720019904CB8F7AA43166CEEB2F18DAB41@RTITMBSVM03.realtek.com.tw>
On 03.09.2019 05:16, Hayes Wang wrote:
> Heiner Kallweit [mailto:hkallweit1@gmail.com]
>> Sent: Tuesday, September 03, 2019 2:37 AM
> [...]
>> Seeing all this code it might be a good idea to switch this driver
>> to phylib, similar to what I did with r8169 some time ago.
>
> It is too complex to be completed for me at the moment.
> If this patch is unacceptable, I would submit other
> patches first. Thanks.
>
My remark isn't directly related to your patch and wasn't
meant as an immediate ToDo. It's just a hint, because I think
using phylib could help to significantly simplify the driver.
> Best Regards,
> Hayes
>
>
Heiner
next prev parent reply other threads:[~2019-09-03 6:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 11:52 Hayes Wang
2019-09-02 18:36 ` Heiner Kallweit
2019-09-03 3:16 ` Hayes Wang
2019-09-03 6:13 ` Heiner Kallweit [this message]
2019-09-03 6:36 ` Hayes Wang
2019-09-03 6:44 ` Heiner Kallweit
2019-09-03 6:55 ` Hayes Wang
2019-09-03 7:12 ` Heiner Kallweit
2019-09-03 7:36 ` Hayes Wang
2019-09-04 22:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa9513ff-3cef-4b9f-ecbd-1310660a911c@gmail.com \
--to=hkallweit1@gmail.com \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®