From: Hayes Wang <hayeswang@realtek.com>
To: Oliver Neukum <oneukum@suse.com>
Cc: nic_swsd <nic_swsd@realtek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH net 2/3] r8152: fix remote wakeup
Date: Thu, 23 Jul 2015 11:30:30 +0000 [thread overview]
Message-ID: <0835B3720019904CB8F7AA43166CEEB2F3ACFE@RTITMBSV03.realtek.com.tw> (raw)
In-Reply-To: <1437647246.4377.33.camel@suse.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1123 bytes --]
Oliver Neukum [mailto:oneukum@suse.com]
[...]
> If the device does not support remote wakeup and the driver enables it, runtime
> power management will be switched off.
> That is the current state and it means that devices which don't support remote
> wakeup cannot do runtime power management at all. But the driver is correct.
>
> The only time a device that doesn't support remote wakeup can do runtime power
> managent is when no packets can be received that is while the interface is down. If
> you want to allow that you must not set needs_remote_wakeup in probe(), but you
> must set it in open() because it is necessary for runtime power management as I
> explained above.
>
> Sorry for the length of this mail, but I wanted to make sure I am absolutely clear
> this time.
Thanks for you explanation. I focus on the wrong point. You mean this would cause
the problem for runtime suspend. I would rethink my method and correct it.
Best Regards,
Hayes
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next prev parent reply other threads:[~2015-07-23 11:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 7:09 [PATCH net 0/3] r8152: issues fix Hayes Wang
2015-07-23 7:09 ` [PATCH net 1/3] r8152: fix the issue about U1/U2 Hayes Wang
2015-07-23 7:09 ` [PATCH net 2/3] r8152: fix remote wakeup Hayes Wang
2015-07-23 8:30 ` Oliver Neukum
2015-07-23 9:55 ` Hayes Wang
2015-07-23 10:27 ` Oliver Neukum
2015-07-23 11:30 ` Hayes Wang [this message]
2015-07-23 7:09 ` [PATCH net 3/3] r8152: don't enable napi before rx ready Hayes Wang
2015-07-24 5:54 ` [PATCH net v2 0/3] r8152: issues fix Hayes Wang
2015-07-24 5:54 ` [PATCH net v2 1/3] r8152: fix the issue about U1/U2 Hayes Wang
2015-07-24 5:54 ` [PATCH net v2 2/3] r8152: fix wakeup settings Hayes Wang
2015-07-24 5:54 ` [PATCH net v2 3/3] r8152: don't enable napi before rx ready Hayes Wang
2015-07-27 7:56 ` [PATCH net v2 0/3] r8152: issues fix David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0835B3720019904CB8F7AA43166CEEB2F3ACFE@RTITMBSV03.realtek.com.tw \
--to=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®