* [PATCH -next] soc: qcom: Make QCOM_RPMPD depend on OF
@ 2022-08-20 11:32 YueHaibing
2022-08-23 1:21 ` Randy Dunlap
2022-08-29 23:46 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2022-08-20 11:32 UTC (permalink / raw)
To: agross, bjorn.andersson, konrad.dybcio
Cc: linux-arm-msm, linux-kernel, YueHaibing
WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS_OF
Depends on [n]: PM_GENERIC_DOMAINS [=y] && OF [=n]
Selected by [m]:
- QCOM_RPMPD [=m] && PM [=y] && QCOM_SMD_RPM [=m]
PM_GENERIC_DOMAINS_OF depends on OF, so QCOM_RPMPD also depends on it.
Fixes: 7d0221fb5912 ("soc/qcom: Make QCOM_RPMPD select PM_GENERIC_DOMAINS/_OF")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/soc/qcom/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
index e0d7a5459562..024e420f1bb7 100644
--- a/drivers/soc/qcom/Kconfig
+++ b/drivers/soc/qcom/Kconfig
@@ -129,7 +129,7 @@ config QCOM_RPMHPD
config QCOM_RPMPD
tristate "Qualcomm RPM Power domain driver"
- depends on PM
+ depends on PM && OF
depends on QCOM_SMD_RPM
select PM_GENERIC_DOMAINS
select PM_GENERIC_DOMAINS_OF
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] soc: qcom: Make QCOM_RPMPD depend on OF
2022-08-20 11:32 [PATCH -next] soc: qcom: Make QCOM_RPMPD depend on OF YueHaibing
@ 2022-08-23 1:21 ` Randy Dunlap
2022-08-29 23:46 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2022-08-23 1:21 UTC (permalink / raw)
To: YueHaibing, agross, bjorn.andersson, konrad.dybcio
Cc: linux-arm-msm, linux-kernel
On 8/20/22 04:32, YueHaibing wrote:
> WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS_OF
> Depends on [n]: PM_GENERIC_DOMAINS [=y] && OF [=n]
> Selected by [m]:
> - QCOM_RPMPD [=m] && PM [=y] && QCOM_SMD_RPM [=m]
>
> PM_GENERIC_DOMAINS_OF depends on OF, so QCOM_RPMPD also depends on it.
>
> Fixes: 7d0221fb5912 ("soc/qcom: Make QCOM_RPMPD select PM_GENERIC_DOMAINS/_OF")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Works for me. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> ---
> drivers/soc/qcom/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index e0d7a5459562..024e420f1bb7 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -129,7 +129,7 @@ config QCOM_RPMHPD
>
> config QCOM_RPMPD
> tristate "Qualcomm RPM Power domain driver"
> - depends on PM
> + depends on PM && OF
> depends on QCOM_SMD_RPM
> select PM_GENERIC_DOMAINS
> select PM_GENERIC_DOMAINS_OF
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] soc: qcom: Make QCOM_RPMPD depend on OF
2022-08-20 11:32 [PATCH -next] soc: qcom: Make QCOM_RPMPD depend on OF YueHaibing
2022-08-23 1:21 ` Randy Dunlap
@ 2022-08-29 23:46 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2022-08-29 23:46 UTC (permalink / raw)
To: yuehaibing, Bjorn Andersson, agross, konrad.dybcio
Cc: linux-kernel, linux-arm-msm
On Sat, 20 Aug 2022 19:32:02 +0800, YueHaibing wrote:
> WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS_OF
> Depends on [n]: PM_GENERIC_DOMAINS [=y] && OF [=n]
> Selected by [m]:
> - QCOM_RPMPD [=m] && PM [=y] && QCOM_SMD_RPM [=m]
>
> PM_GENERIC_DOMAINS_OF depends on OF, so QCOM_RPMPD also depends on it.
>
> [...]
Applied, thanks!
[1/1] soc: qcom: Make QCOM_RPMPD depend on OF
commit: 0e5732e4d58437feded42fb459384904eb317e91
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-29 23:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-20 11:32 [PATCH -next] soc: qcom: Make QCOM_RPMPD depend on OF YueHaibing
2022-08-23 1:21 ` Randy Dunlap
2022-08-29 23:46 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®