From: Devarsh Thakkar <devarsht@ti.com>
To: Randy Dunlap <rdunlap@infradead.org>, <mchehab@kernel.org>,
<hverkuil-cisco@xs4all.nl>, <linux-media@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <benjamin.gaignard@collabora.com>,
<sebastian.fricke@collabora.com>, <akpm@linux-foundation.org>,
<gregkh@linuxfoundation.org>, <andriy.shevchenko@linux.intel.com>,
<adobriyan@gmail.com>, <jani.nikula@intel.com>,
<p.zabel@pengutronix.de>, <airlied@gmail.com>, <daniel@ffwll.ch>,
<dri-devel@lists.freedesktop.org>, <corbet@lwn.net>,
<broonie@kernel.org>, <linux-doc@vger.kernel.org>
Cc: <laurent.pinchart@ideasonboard.com>, <praneeth@ti.com>,
<nm@ti.com>, <vigneshr@ti.com>, <a-bhatia1@ti.com>,
<j-luthra@ti.com>, <b-brnich@ti.com>, <detheridge@ti.com>,
<p-mantena@ti.com>, <vijayp@ti.com>, <andrzej.p@collabora.com>,
<nicolas@ndufresne.ca>, <davidgow@google.com>,
<dlatypov@google.com>
Subject: Re: [PATCH v10 07/11] Documentation: core-api: Add math.h macros and functions
Date: Fri, 31 May 2024 16:27:23 +0530 [thread overview]
Message-ID: <0858f5d9-a694-7ee4-0edf-3f0610703b92@ti.com> (raw)
In-Reply-To: <4951656c-2d15-49f6-89d8-aa7b5c333ec7@infradead.org>
Hi Randy,
Thanks for the review.
On 31/05/24 04:14, Randy Dunlap wrote:
>
>
> On 5/30/24 10:17 AM, Devarsh Thakkar wrote:
>> Add documentation for rounding, scaling, absolute value and difference,
>> 32-bit division related macros and functions exported by math.h header
>> file.
>>
>> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
>> ---
>> V1->V9 (No change)
>> V10: Patch introduced
>> ---
>> Documentation/core-api/kernel-api.rst | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/core-api/kernel-api.rst b/Documentation/core-api/kernel-api.rst
>> index ae92a2571388..fb467783d491 100644
>> --- a/Documentation/core-api/kernel-api.rst
>> +++ b/Documentation/core-api/kernel-api.rst
>> @@ -185,6 +185,12 @@ Division Functions
>> .. kernel-doc:: lib/math/gcd.c
>> :export:
>>
>> +Rounding, absolute value, scaling and 32bit division functions
>
> 32-bit
> please.
>
Good catch. Also I see some division functions supporting non-32bit functions
too, so I would make it as below :
Rounding, absolute value, division and 32-bit scaling functions
---------------------------------------------------------------
Regards
Devarsh
next prev parent reply other threads:[~2024-05-31 10:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 16:59 [PATCH v10 00/11] Add V4L2 M2M Driver for E5010 JPEG Encoder Devarsh Thakkar
2024-05-30 17:07 ` [PATCH v10 01/11] media: dt-bindings: Add Imagination " Devarsh Thakkar
2024-05-30 17:08 ` [PATCH v10 02/11] media: imagination: Add E5010 JPEG Encoder driver Devarsh Thakkar
2024-05-30 17:10 ` [PATCH v10 03/11] media: v4l2-jpeg: Export reference quantization and huffman tables Devarsh Thakkar
2024-05-30 17:11 ` [PATCH v10 04/11] media: imagination: Use exported tables from v4l2-jpeg core Devarsh Thakkar
2024-05-30 17:11 ` [PATCH v10 05/11] media: verisilicon : Use exported tables from v4l2-jpeg for hantro codec Devarsh Thakkar
2024-05-30 17:12 ` [PATCH v10 06/11] math.h: Add macros for rounding to closest value Devarsh Thakkar
2024-05-30 19:19 ` Andy Shevchenko
2024-05-31 8:36 ` Devarsh Thakkar
2024-05-30 17:17 ` [PATCH v10 07/11] Documentation: core-api: Add math.h macros and functions Devarsh Thakkar
2024-05-30 19:21 ` Andy Shevchenko
2024-05-31 8:44 ` Devarsh Thakkar
2024-05-30 22:44 ` Randy Dunlap
2024-05-31 10:57 ` Devarsh Thakkar [this message]
2024-05-30 17:18 ` [PATCH v10 08/11] lib: add basic KUnit test for lib/math Devarsh Thakkar
2024-05-30 19:23 ` Andy Shevchenko
2024-05-31 8:40 ` Devarsh Thakkar
2024-05-30 17:18 ` [PATCH v10 09/11] lib: math_kunit: Add tests for new macros related to rounding to nearest value Devarsh Thakkar
2024-05-30 17:19 ` [PATCH v10 10/11] media: imagination: Round to closest multiple for cropping region Devarsh Thakkar
2024-05-30 17:19 ` [PATCH v10 11/11] gpu: ipu-v3: Use generic macro for rounding closest to specified value Devarsh Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0858f5d9-a694-7ee4-0edf-3f0610703b92@ti.com \
--to=devarsht@ti.com \
--cc=a-bhatia1@ti.com \
--cc=adobriyan@gmail.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andrzej.p@collabora.com \
--cc=b-brnich@ti.com \
--cc=benjamin.gaignard@collabora.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@ffwll.ch \
--cc=davidgow@google.com \
--cc=detheridge@ti.com \
--cc=dlatypov@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=j-luthra@ti.com \
--cc=jani.nikula@intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=nm@ti.com \
--cc=p-mantena@ti.com \
--cc=p.zabel@pengutronix.de \
--cc=praneeth@ti.com \
--cc=rdunlap@infradead.org \
--cc=sebastian.fricke@collabora.com \
--cc=vigneshr@ti.com \
--cc=vijayp@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®