From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Shenghao Ding <shenghao-ding@ti.com>,
broonie@kernel.org, conor+dt@kernel.org
Cc: robh+dt@kernel.org, andriy.shevchenko@linux.intel.com,
kevin-lu@ti.com, baojun.xu@ti.com, devicetree@vger.kernel.org,
lgirdwood@gmail.com, perex@perex.cz,
pierre-louis.bossart@linux.intel.com, 13916275206@139.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
liam.r.girdwood@intel.com, soyer@irl.hu, jkhuang3@ti.com,
tiwai@suse.de, pdjuandi@ti.com, j-mcpherson@ti.com,
navada@ti.com
Subject: Re: [PATCH v1 3/4] ASoc: pcm6240: Add compile item for pcm6240 codec driver
Date: Tue, 23 Jan 2024 12:25:33 +0100 [thread overview]
Message-ID: <08809d8b-a474-42e8-8a25-edc94e7d9723@linaro.org> (raw)
In-Reply-To: <20240123111411.850-3-shenghao-ding@ti.com>
On 23/01/2024 12:14, Shenghao Ding wrote:
> PCM6240 driver implements a flexible and configurable setting for register
> and filter coefficients, to one, two or even multiple PCM6240 Family Audio
> chips.
>
> Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
>
> ---
> Change in v1:
> - Add compile item for pcm6240 codec driver
So before you added dead code? No, please add a working code, so squash
the patches.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-23 11:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 11:14 [PATCH v1 1/4] ASoc: pcm6240: Create pcm6240 codec driver code Shenghao Ding
2024-01-23 11:14 ` [PATCH v1 2/4] ASoc: pcm6240: Create header file for " Shenghao Ding
2024-01-23 11:14 ` [PATCH v1 3/4] ASoc: pcm6240: Add compile item for pcm6240 codec driver Shenghao Ding
2024-01-23 11:25 ` Krzysztof Kozlowski [this message]
2024-01-23 19:13 ` Mark Brown
2024-01-23 11:14 ` [PATCH v1 4/4] ASoc: dt-bindings: Create yaml file " Shenghao Ding
2024-01-23 11:25 ` Krzysztof Kozlowski
2024-01-23 15:01 ` Mark Brown
2024-01-23 15:04 ` Krzysztof Kozlowski
2024-01-24 10:10 ` [EXTERNAL] " Ding, Shenghao
2024-01-25 7:39 ` Ding, Shenghao
2024-01-25 7:50 ` Krzysztof Kozlowski
2024-01-25 8:46 ` Ding, Shenghao
2024-01-25 8:57 ` Krzysztof Kozlowski
2024-01-28 15:11 ` [PATCH v1 1/4] ASoc: pcm6240: Create pcm6240 codec driver code Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08809d8b-a474-42e8-8a25-edc94e7d9723@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=13916275206@139.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j-mcpherson@ti.com \
--cc=jkhuang3@ti.com \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=navada@ti.com \
--cc=pdjuandi@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®