From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Ding, Shenghao" <shenghao-ding@ti.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"Lu, Kevin" <kevin-lu@ti.com>, "Xu, Baojun" <baojun.xu@ti.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"pierre-louis.bossart@linux.intel.com"
<pierre-louis.bossart@linux.intel.com>,
"13916275206@139.com" <13916275206@139.com>,
"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"liam.r.girdwood@intel.com" <liam.r.girdwood@intel.com>,
"soyer@irl.hu" <soyer@irl.hu>,
"Huang, Jonathan" <jkhuang3@ti.com>,
"tiwai@suse.de" <tiwai@suse.de>,
"Djuandi, Peter" <pdjuandi@ti.com>,
"McPherson, Jeff" <j-mcpherson@ti.com>,
"Navada Kanyana, Mukund" <navada@ti.com>
Subject: Re: [EXTERNAL] Re: [PATCH v1 4/4] ASoc: dt-bindings: Create yaml file for pcm6240 codec driver
Date: Thu, 25 Jan 2024 08:50:01 +0100 [thread overview]
Message-ID: <d8f00ea9-3bb2-4b17-bbc7-48800516e408@linaro.org> (raw)
In-Reply-To: <a6c6cad6efc647ba8f0c828ffdb3a54f@ti.com>
On 25/01/2024 08:39, Ding, Shenghao wrote:
>>
>> Why do you repeat the reg constraints? This does not seem needed.
>>
>>> + interrupts: false
>>> +
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + enum:
>>> + - ti,pcm3140
>>> + - ti,pcm5140
>>> + - ti,pcm6140
>>> + - ti,pcmd3180
>>> + then:
>>> + properties:
>>> + reg:
>>> + description:
>>> + I2C address, in multiple pcmdevices case, all the i2c address
>>> + aggregate as one Audio Device to support multiple audio slots.
>>> + maxItems: 4
>>> + minItems: 1
>>
You did not respond to any of other comments, therefore I assume you
agree with them 100% and you will implement them fully.
>> Drop entire if
> How to convey ti,pcm1690 does not support interrupt, and others support if I remove this if
How? There is no pcm1690 here.
BTW, add missing line breaks, especially before next blocks like
additionalProperties.
>>
>>> + items:
>>> + minimum: 0x4c
>>> + maximum: 0x4f
>>> +
>
> BR
> Shenghao Ding
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-25 7:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 11:14 [PATCH v1 1/4] ASoc: pcm6240: Create pcm6240 codec driver code Shenghao Ding
2024-01-23 11:14 ` [PATCH v1 2/4] ASoc: pcm6240: Create header file for " Shenghao Ding
2024-01-23 11:14 ` [PATCH v1 3/4] ASoc: pcm6240: Add compile item for pcm6240 codec driver Shenghao Ding
2024-01-23 11:25 ` Krzysztof Kozlowski
2024-01-23 19:13 ` Mark Brown
2024-01-23 11:14 ` [PATCH v1 4/4] ASoc: dt-bindings: Create yaml file " Shenghao Ding
2024-01-23 11:25 ` Krzysztof Kozlowski
2024-01-23 15:01 ` Mark Brown
2024-01-23 15:04 ` Krzysztof Kozlowski
2024-01-24 10:10 ` [EXTERNAL] " Ding, Shenghao
2024-01-25 7:39 ` Ding, Shenghao
2024-01-25 7:50 ` Krzysztof Kozlowski [this message]
2024-01-25 8:46 ` Ding, Shenghao
2024-01-25 8:57 ` Krzysztof Kozlowski
2024-01-28 15:11 ` [PATCH v1 1/4] ASoc: pcm6240: Create pcm6240 codec driver code Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8f00ea9-3bb2-4b17-bbc7-48800516e408@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=13916275206@139.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j-mcpherson@ti.com \
--cc=jkhuang3@ti.com \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=navada@ti.com \
--cc=pdjuandi@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®