Re: [PATCH v2] drm/bridge: dw-hdmi-qp: fix multi-channel audio output

[Cristian Ciocaltea <cristian.ciocaltea@collabora.com>]

Hi Luca,

On 3/17/26 7:35 PM, Luca Ceresoli wrote:
> Hello Christian, Cristian, Jonas,
> 
> On Tue Mar 17, 2026 at 5:49 PM CET, Christian Hewitt wrote:
>>> On 17 Mar 2026, at 8:16 pm, Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:
>>>
>>> Hello Christian,
>>>
>>> On Sat Feb 28, 2026 at 12:28 PM CET, Christian Hewitt wrote:
>>>> From: Jonas Karlman <jonas@kwiboo.se>
>>>>
>>>> Channel Allocation (PB4) and Level Shift Information (PB5) are
>>>> configured with values from PB1 and PB2 due to the wrong offset
>>>> being used. This results in missing audio channels or incorrect
>>>> speaker placement when playing multi-channel audio.
>>>>
>>>> Use the correct offset to fix multi-channel audio output.
>>>>
>>>> Fixes: fd0141d1a8a2 ("drm/bridge: synopsys: Add audio support for dw-hdmi-qp")
>>>> Reported-by: Christian Hewitt <christianshewitt@gmail.com>
>>>> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
>>>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>>>> Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>>>
>>> While applying this patch to drm-mics-fixes, checkpatch complains:
>>>
>>>  -:14: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
>>>
>>> You can send v3 with the link, or just reply with the link and I'll take
>>> care of adding it to the commit message.
>>
>> Apologies, it looks like use of Reported-by was tightened since I last
>> used it, and there’s no official report anywhere I can link to (it was
>> all done in private channels) so better to just drop it from the v2 patch
>> if that’s possible? - if not I can send a v3 without it.
> 
> Thanks for the quick feedback.
> 
> I applied keeping the commit message as is. In lack of a public discussion
> I guess the 'Reported-by' is somewhat informative anyway. I read the
> checkpatch as a general suggestion, not a hard rule.
> 
> So now this patch is on drm-misc-fixes, but drm-misc-fixes and
> drm-misc-next are now conflicting because of other changes by Cristian
> Ciocaltea applied in the meanwhile to drm-misc-next, and particularly
> commit 3ea699b56d31 ("drm/bridge: dw-hdmi-qp: Rework Audio InfoFrame
> handler").
> 
> Cristian, Christian (heh), Jonas, could you please check whether the code
> on drm-misc-next has or not the bug that is fixed here? And if it still
> has, send a fix based on current drm-misc-next?

The conflicting commit in drm-misc-next (i.e. 3ea699b56d31) implicitly resolves
this audio related issue as well, hence there is no need for any further action.

Regards,
Cristian