From: Shawn Lin <shawn.lin@rock-chips.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Evgeniy Didin <Evgeniy.Didin@synopsys.com>,
Doug Anderson <dianders@chromium.org>,
shawn.lin@rock-chips.com, Jaehoon Chung <jh80.chung@samsung.com>,
Qing Xia <xiaqing17@hisilicon.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: dw_mmc: fix card threshold control configuration
Date: Mon, 11 Jun 2018 22:17:58 +0800 [thread overview]
Message-ID: <08a08d60-8176-df54-ff0e-ffc195f40d6c@rock-chips.com> (raw)
In-Reply-To: <CAPDyKFo7FP5bL8doK3P749Rcyzh_H-3SzG+GZVJb2pp9j_ZH_A@mail.gmail.com>
On 2018/6/11 20:20, Ulf Hansson wrote:
> + Shawn Lin, Evgeniy Didin, Doug Andersson
>
> On 29 May 2018 at 12:38, Qing Xia <xiaqing17@hisilicon.com> wrote:
>> From: x00270170 <xiaqing17@hisilicon.com>
>>
>> Card write threshold control is supposed to be set since controller
>> version 2.80a for data write in HS400 mode and data read in
>> HS200/HS400/SDR104 mode. However the current code returns without
>> configuring it in the case of data writing in HS400 mode.
>> Meanwhile the patch fixes that the current code goes to
>> 'disable' when doing data reading in HS400 mode.
>>
I'm more or less unable to review this, as I don't have 2.80a databook,
nor a such platform to verify it. :(
>> Signed-off-by: Qing Xia <xiaqing17@hisilicon.com>
>
> This looks good to me. However, it seems like Jaehoon has been busy,
> no response yet.
>
> I have looped in a few more people to see if they thinks this makes sense.
>
> Kind regards
> Uffe
>
>> ---
>> drivers/mmc/host/dw_mmc.c | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
>> index 29a1afa..3ee8f57 100644
>> --- a/drivers/mmc/host/dw_mmc.c
>> +++ b/drivers/mmc/host/dw_mmc.c
>> @@ -1065,8 +1065,8 @@ static void dw_mci_ctrl_thld(struct dw_mci *host, struct mmc_data *data)
>> * It's used when HS400 mode is enabled.
>> */
>> if (data->flags & MMC_DATA_WRITE &&
>> - !(host->timing != MMC_TIMING_MMC_HS400))
>> - return;
>> + host->timing != MMC_TIMING_MMC_HS400)
>> + goto disable;
>>
>> if (data->flags & MMC_DATA_WRITE)
>> enable = SDMMC_CARD_WR_THR_EN;
>> @@ -1074,7 +1074,8 @@ static void dw_mci_ctrl_thld(struct dw_mci *host, struct mmc_data *data)
>> enable = SDMMC_CARD_RD_THR_EN;
>>
>> if (host->timing != MMC_TIMING_MMC_HS200 &&
>> - host->timing != MMC_TIMING_UHS_SDR104)
>> + host->timing != MMC_TIMING_UHS_SDR104 &&
>> + host->timing != MMC_TIMING_MMC_HS400)
>> goto disable;
>>
>> blksz_depth = blksz / (1 << host->data_shift);
>> --
>> 2.8.1
>>
>
>
>
--
Best Regards
Shawn Lin
next prev parent reply other threads:[~2018-06-11 14:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 10:38 Qing Xia
2018-06-11 12:20 ` Ulf Hansson
2018-06-11 14:17 ` Shawn Lin [this message]
2018-07-02 17:00 ` Doug Anderson
2018-07-02 13:16 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08a08d60-8176-df54-ff0e-ffc195f40d6c@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=Evgeniy.Didin@synopsys.com \
--cc=dianders@chromium.org \
--cc=jh80.chung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=xiaqing17@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®