From: Mark O'Donovan <shiftee@posteo.net>
To: Sagi Grimberg <sagi@grimberg.me>, linux-kernel@vger.kernel.org
Cc: linux-nvme@lists.infradead.org, hch@lst.de, axboe@kernel.dk,
kbusch@kernel.org, hare@suse.de
Subject: Re: [PATCH 1/2] nvme-tcp: auth success1 msg always includes resp
Date: Tue, 29 Aug 2023 23:37:15 +0000 [thread overview]
Message-ID: <08a9b45b-f1e8-3fac-3d02-54b7bb31d954@posteo.net> (raw)
In-Reply-To: <34c159dc-c534-2329-4049-7e9e8a53cd4d@grimberg.me>
On 29/08/2023 12:47, Sagi Grimberg wrote:
> This is not nvme-tcp specific.
> prefix should be "nvme-auth: ..."
>
> I'm assuming that this passes blktests?
>
> Nonetheless looks fine to me.
Yes, the nvme auth blktests all pass with this change.
Sorry about the prefix. Will fix if doing another revision.
next prev parent reply other threads:[~2023-08-29 23:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 21:20 Mark O'Donovan
2023-08-28 21:20 ` [PATCH 2/2] nvme-tcp: always set valid seq_num in dhchap reply Mark O'Donovan
2023-08-29 11:48 ` Sagi Grimberg
2023-08-29 11:47 ` [PATCH 1/2] nvme-tcp: auth success1 msg always includes resp Sagi Grimberg
2023-08-29 23:37 ` Mark O'Donovan [this message]
2023-09-06 10:59 ` Hannes Reinecke
2023-09-12 11:39 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08a9b45b-f1e8-3fac-3d02-54b7bb31d954@posteo.net \
--to=shiftee@posteo.net \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®