From: Hannes Reinecke <hare@suse.de>
To: Mark O'Donovan <shiftee@posteo.net>, linux-kernel@vger.kernel.org
Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de,
axboe@kernel.dk, kbusch@kernel.org
Subject: Re: [PATCH 1/2] nvme-tcp: auth success1 msg always includes resp
Date: Wed, 6 Sep 2023 12:59:03 +0200 [thread overview]
Message-ID: <47ea3835-2494-4601-9da9-02831a1b4a4b@suse.de> (raw)
In-Reply-To: <20230828212033.3244512-1-shiftee@posteo.net>
On 8/28/23 23:20, Mark O'Donovan wrote:
> In cases where RVALID is false, the response is still transmitted,
> but is cleared to zero.
>
> Relevant extract from the spec:
> Response R2, if valid (i.e., if the RVALID field is set to 01h),
> cleared to 0h otherwise
>
> Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
> ---
> drivers/nvme/host/auth.c | 5 +----
> include/linux/nvme.h | 2 +-
> 2 files changed, 2 insertions(+), 5 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
next prev parent reply other threads:[~2023-09-06 10:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 21:20 Mark O'Donovan
2023-08-28 21:20 ` [PATCH 2/2] nvme-tcp: always set valid seq_num in dhchap reply Mark O'Donovan
2023-08-29 11:48 ` Sagi Grimberg
2023-08-29 11:47 ` [PATCH 1/2] nvme-tcp: auth success1 msg always includes resp Sagi Grimberg
2023-08-29 23:37 ` Mark O'Donovan
2023-09-06 10:59 ` Hannes Reinecke [this message]
2023-09-12 11:39 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47ea3835-2494-4601-9da9-02831a1b4a4b@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=shiftee@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®