* [PATCH] staging: vboxvideo: make a couple of funcs static
@ 2018-10-10 20:17 Craig Kewley
2018-10-11 8:53 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Craig Kewley @ 2018-10-10 20:17 UTC (permalink / raw)
To: Greg Kroah-Hartman, Hans de Goede, Sean Paul, devel, linux-kernel
Cc: Craig Kewley
Fix Sparse warnings:
drivers/staging/vboxvideo/vbox_mode.c:309:6: warning:
symbol 'vbox_primary_atomic_disable' was not declared. Should it be static?
drivers/staging/vboxvideo/vbox_mode.c:452:6: warning:
symbol 'vbox_cursor_atomic_disable' was not declared. Should it be static?
Signed-off-by: Craig Kewley <craigkewley@gmail.com>
---
drivers/staging/vboxvideo/vbox_mode.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c
index 042e4f384df9..deed28c7a1db 100644
--- a/drivers/staging/vboxvideo/vbox_mode.c
+++ b/drivers/staging/vboxvideo/vbox_mode.c
@@ -306,8 +306,8 @@ static void vbox_primary_atomic_update(struct drm_plane *plane,
plane->state->src_y >> 16);
}
-void vbox_primary_atomic_disable(struct drm_plane *plane,
- struct drm_plane_state *old_state)
+static void vbox_primary_atomic_disable(struct drm_plane *plane,
+ struct drm_plane_state *old_state)
{
struct drm_crtc *crtc = old_state->crtc;
@@ -449,8 +449,8 @@ static void vbox_cursor_atomic_update(struct drm_plane *plane,
mutex_unlock(&vbox->hw_mutex);
}
-void vbox_cursor_atomic_disable(struct drm_plane *plane,
- struct drm_plane_state *old_state)
+static void vbox_cursor_atomic_disable(struct drm_plane *plane,
+ struct drm_plane_state *old_state)
{
struct vbox_private *vbox =
container_of(plane->dev, struct vbox_private, ddev);
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: vboxvideo: make a couple of funcs static
2018-10-10 20:17 [PATCH] staging: vboxvideo: make a couple of funcs static Craig Kewley
@ 2018-10-11 8:53 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2018-10-11 8:53 UTC (permalink / raw)
To: Craig Kewley, Greg Kroah-Hartman, Sean Paul, devel, linux-kernel
Hi,
On 10-10-18 22:17, Craig Kewley wrote:
> Fix Sparse warnings:
> drivers/staging/vboxvideo/vbox_mode.c:309:6: warning:
> symbol 'vbox_primary_atomic_disable' was not declared. Should it be static?
>
> drivers/staging/vboxvideo/vbox_mode.c:452:6: warning:
> symbol 'vbox_cursor_atomic_disable' was not declared. Should it be static?
>
> Signed-off-by: Craig Kewley <craigkewley@gmail.com>
Thanks.
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/staging/vboxvideo/vbox_mode.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c
> index 042e4f384df9..deed28c7a1db 100644
> --- a/drivers/staging/vboxvideo/vbox_mode.c
> +++ b/drivers/staging/vboxvideo/vbox_mode.c
> @@ -306,8 +306,8 @@ static void vbox_primary_atomic_update(struct drm_plane *plane,
> plane->state->src_y >> 16);
> }
>
> -void vbox_primary_atomic_disable(struct drm_plane *plane,
> - struct drm_plane_state *old_state)
> +static void vbox_primary_atomic_disable(struct drm_plane *plane,
> + struct drm_plane_state *old_state)
> {
> struct drm_crtc *crtc = old_state->crtc;
>
> @@ -449,8 +449,8 @@ static void vbox_cursor_atomic_update(struct drm_plane *plane,
> mutex_unlock(&vbox->hw_mutex);
> }
>
> -void vbox_cursor_atomic_disable(struct drm_plane *plane,
> - struct drm_plane_state *old_state)
> +static void vbox_cursor_atomic_disable(struct drm_plane *plane,
> + struct drm_plane_state *old_state)
> {
> struct vbox_private *vbox =
> container_of(plane->dev, struct vbox_private, ddev);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-11 8:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-10 20:17 [PATCH] staging: vboxvideo: make a couple of funcs static Craig Kewley
2018-10-11 8:53 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®