mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Maciej Wieczor-Retman <m.wieczorretman@pm.me>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
	linux-kernel@vger.kernel.org, sohil.mehta@intel.com,
	Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
	Ingo Molnar <mingo@redhat.com>, Jon Kohler <jon@nutanix.com>,
	Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Thomas Gleixner <tglx@kernel.org>,
	Tony Luck <tony.luck@intel.com>,
	x86@kernel.org
Subject: Re: [PATCH 4/6] x86/cpu: Add platform ID to CPU info structure
Date: Tue, 20 Jan 2026 08:12:53 -0800	[thread overview]
Message-ID: <08d527fd-4470-40bd-a458-5b4d52bcdc4d@intel.com> (raw)
In-Reply-To: <aW-i4Sqdkv8qVOtJ@wieczorr-mobl1.localdomain>

On 1/20/26 08:03, Maciej Wieczor-Retman wrote:
> On 2026-01-20 at 07:13:31 -0800, Dave Hansen wrote:
>> On 1/20/26 06:34, Maciej Wieczor-Retman wrote:
>>>> 	__u8			x86_stepping;
>>>> +	__u8			x86_platform_id; /* Intel-only. 3 bits */
>>> Should platform ID be added to print_cpu_info()?
>>>
>>> So it's printed alongside (family: 0xN model: 0xN, stepping: 0xN)
>> It's not a horrible idea, but it's also relatively worthless compared to
>> the other three. I'd certainly take a look at it if someone sent a
>> patch, but I'm not really looking to add more to this series that
>> doesn't _need_ to be here.
> Fair enough, and I suppose if someone really needs this information they can
> just read the MSR themselves.

Right. If they get some weird "old_microcode" output, they can go use
rdmsr(1) to debug it if they're root. It might make debugging issues a
_wee_ bit easier to have the platform_id in dmesg, but it's only used in
two places in the kernel, so the value is *MUCH* lower than
family/model/stepping which are used all over.

Also, despite being 6 patches, this series is _just_ about as small as I
can make it to fix the bug at hand. Even if we decided a pr_whatever()
would be really nice, it's not a bug fix and would (IMNHO) need to be in
a separate series.

  reply	other threads:[~2026-01-20 16:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-20 14:34 Maciej Wieczor-Retman
2026-01-20 15:13 ` Dave Hansen
2026-01-20 16:03   ` Maciej Wieczor-Retman
2026-01-20 16:12     ` Dave Hansen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-02-06 23:14 [PATCH 0/6] [v2] x86/cpu: Take Intel platform into account for old microcode checks Dave Hansen
2026-02-06 23:14 ` [PATCH 4/6] x86/cpu: Add platform ID to CPU info structure Dave Hansen
2026-02-08 21:37   ` Borislav Petkov
2026-02-11 18:40     ` Dave Hansen
2026-02-12 15:22       ` Borislav Petkov
2026-02-10 23:23   ` Sohil Mehta
2026-01-19 19:50 [PATCH 0/6] x86/cpu: Take Intel platform into account for old microcode checks Dave Hansen
2026-01-19 19:50 ` [PATCH 4/6] x86/cpu: Add platform ID to CPU info structure Dave Hansen
2026-01-20  3:14   ` Chao Gao
2026-01-20 15:22     ` Dave Hansen
2026-01-21  2:03       ` Chao Gao
2026-01-20  8:27   ` Andy Shevchenko
2026-01-20 15:06     ` Dave Hansen
2026-01-20 20:44       ` Andy Shevchenko
2026-01-20 20:48         ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08d527fd-4470-40bd-a458-5b4d52bcdc4d@intel.com \
    --to=dave.hansen@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jon@nutanix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.wieczorretman@pm.me \
    --cc=mingo@redhat.com \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=peterz@infradead.org \
    --cc=sohil.mehta@intel.com \
    --cc=tglx@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome