[PATCH 0/2] cpufreq: Init epp_policy as CPUFREQ_POLICY_UNKNOWN

[PATCH 0/2] cpufreq: Init epp_policy as CPUFREQ_POLICY_UNKNOWN

[Christian Loehle]

Just a tiny cleanup for consistency, when offlining epp_policy are
reset to CPUFREQ_POLICY_UNKNOWN, but initialized to equivalent 0.

No functional changes intended.

Christian Loehle (2):
  cpufreq: amd-pstate: Use CPUFREQ_POLICY_UNKNOWN
  cpufreq: intel_pstate: Use CPUFREQ_POLICY_UNKNOWN

 drivers/cpufreq/amd-pstate.c   | 2 +-
 drivers/cpufreq/intel_pstate.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--
2.34.1

[PATCH 1/2] cpufreq: amd-pstate: Use CPUFREQ_POLICY_UNKNOWN

[Christian Loehle]

epp_policy uses the same values as cpufreq_policy.policy and resets
to CPUFREQ_POLICY_UNKNOWN during offlining. Be consistent about
it and initialize to CPUFREQ_POLICY_UNKNOWN instead of 0, too.

No functional change intended.

Cc: Huang Rui <ray.huang@amd.com>
Cc: <gautham.shenoy@amd.com>
Cc: Mario Limonciello <mario.limonciello@amd.com>
Cc: Perry Yuan <perry.yuan@amd.com>
Signed-off-by: Christian Loehle <christian.loehle@arm.com>
---
 drivers/cpufreq/amd-pstate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index d7630bab2516..546e69cbdf76 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -1449,7 +1449,7 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
 		return -ENOMEM;
 
 	cpudata->cpu = policy->cpu;
-	cpudata->epp_policy = 0;
+	cpudata->epp_policy = CPUFREQ_POLICY_UNKNOWN;
 
 	ret = amd_pstate_init_perf(cpudata);
 	if (ret)
-- 
2.34.1

Re: [PATCH 1/2] cpufreq: amd-pstate: Use CPUFREQ_POLICY_UNKNOWN

[Mario Limonciello]

On 12/11/2024 06:26, Christian Loehle wrote:
> epp_policy uses the same values as cpufreq_policy.policy and resets
> to CPUFREQ_POLICY_UNKNOWN during offlining. Be consistent about
> it and initialize to CPUFREQ_POLICY_UNKNOWN instead of 0, too.
> 
> No functional change intended.
> 
> Cc: Huang Rui <ray.huang@amd.com>
> Cc: <gautham.shenoy@amd.com>
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Cc: Perry Yuan <perry.yuan@amd.com>
> Signed-off-by: Christian Loehle <christian.loehle@arm.com>
> ---
>   drivers/cpufreq/amd-pstate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index d7630bab2516..546e69cbdf76 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1449,7 +1449,7 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
>   		return -ENOMEM;
>   
>   	cpudata->cpu = policy->cpu;
> -	cpudata->epp_policy = 0;
> +	cpudata->epp_policy = CPUFREQ_POLICY_UNKNOWN;
>   
>   	ret = amd_pstate_init_perf(cpudata);
>   	if (ret)

Hi,

Thanks for the patch.  In this case it's actually not needed though. 
Some of the in-flight content for 6.14 drops that variable.  This is on 
the superm1/linux.git bleeding-edge branch (which content will promote 
to superm1/linux.git linux-next branch soon and eventually come to 
linux-pm).

https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git/commit/?h=bleeding-edge&id=b8321230569dc17852a7f7adc7715ad07538cbeb

[PATCH 2/2] cpufreq: intel_pstate: Use CPUFREQ_POLICY_UNKNOWN

[Christian Loehle]

epp_policy uses the same values as cpufreq_policy.policy and resets
to CPUFREQ_POLICY_UNKNOWN during offlining. Be consistent about
it and initialize to CPUFREQ_POLICY_UNKNOWN instead of 0, too.

No functional change intended.

Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: Christian Loehle <christian.loehle@arm.com>
---
 drivers/cpufreq/intel_pstate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index b8e2396a708a..5dacd9d26879 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -2709,7 +2709,7 @@ static int intel_pstate_init_cpu(unsigned int cpunum)
 	}
 
 	cpu->epp_powersave = -EINVAL;
-	cpu->epp_policy = 0;
+	cpu->epp_policy = CPUFREQ_POLICY_UNKNOWN;
 
 	intel_pstate_get_cpu_pstates(cpu);
 
-- 
2.34.1

Re: [PATCH 2/2] cpufreq: intel_pstate: Use CPUFREQ_POLICY_UNKNOWN

[Rafael J. Wysocki]

On Wed, Dec 11, 2024 at 1:26 PM Christian Loehle
<christian.loehle@arm.com> wrote:
>
> epp_policy uses the same values as cpufreq_policy.policy and resets
> to CPUFREQ_POLICY_UNKNOWN during offlining. Be consistent about
> it and initialize to CPUFREQ_POLICY_UNKNOWN instead of 0, too.
>
> No functional change intended.
>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Len Brown <lenb@kernel.org>
> Signed-off-by: Christian Loehle <christian.loehle@arm.com>
> ---
>  drivers/cpufreq/intel_pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index b8e2396a708a..5dacd9d26879 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -2709,7 +2709,7 @@ static int intel_pstate_init_cpu(unsigned int cpunum)
>         }
>
>         cpu->epp_powersave = -EINVAL;
> -       cpu->epp_policy = 0;
> +       cpu->epp_policy = CPUFREQ_POLICY_UNKNOWN;
>
>         intel_pstate_get_cpu_pstates(cpu);
>
> --

Applied as 6.14 material, thanks!