[PATCH v1] i3c: mipi-i3c-hci: Use named initializers for platform_device_id's .driver_data

[PATCH v1] i3c: mipi-i3c-hci: Use named initializers for platform_device_id's .driver_data

[Uwe Kleine-König (The Capable Hub)]

The assignment in this driver uses a mixed way to initialize the
platform_device_id array. .name is assigned by name and .driver_data by
position. Unify that to use named assignment for both struct members.
This is needed for a planned change to struct platform_device_id
replacing .driver_data by an anonymous union.

Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
 drivers/i3c/master/mipi-i3c-hci/core.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c
index 3a3a9a3d4dec..e80aa1f5722e 100644
--- a/drivers/i3c/master/mipi-i3c-hci/core.c
+++ b/drivers/i3c/master/mipi-i3c-hci/core.c
@@ -1189,11 +1189,14 @@ static const struct acpi_device_id i3c_hci_acpi_match[] = {
 MODULE_DEVICE_TABLE(acpi, i3c_hci_acpi_match);
 
 static const struct platform_device_id i3c_hci_driver_ids[] = {
-	{ .name = "intel-lpss-i3c", HCI_QUIRK_RPM_ALLOWED |
-				    HCI_QUIRK_RPM_IBI_ALLOWED |
-				    HCI_QUIRK_RPM_PARENT_MANAGED |
-				    HCI_QUIRK_DMA_ABORT_REQUIRES_PIO_RESET |
-				    HCI_QUIRK_DMA_REQUIRES_HC_ABORT },
+	{
+		.name = "intel-lpss-i3c",
+		.driver_data = HCI_QUIRK_RPM_ALLOWED |
+			HCI_QUIRK_RPM_IBI_ALLOWED |
+			HCI_QUIRK_RPM_PARENT_MANAGED |
+			HCI_QUIRK_DMA_ABORT_REQUIRES_PIO_RESET |
+			HCI_QUIRK_DMA_REQUIRES_HC_ABORT,
+	},
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(platform, i3c_hci_driver_ids);

base-commit: 8d6dbbbe3ba62de0a63e962ee004afb848c8e3ac
-- 
2.47.3

Re: [PATCH v1] i3c: mipi-i3c-hci: Use named initializers for platform_device_id's .driver_data

[Adrian Hunter]

On 16/06/2026 17:34, Uwe Kleine-König (The Capable Hub) wrote:
> The assignment in this driver uses a mixed way to initialize the
> platform_device_id array. .name is assigned by name and .driver_data by
> position. Unify that to use named assignment for both struct members.
> This is needed for a planned change to struct platform_device_id
> replacing .driver_data by an anonymous union.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/i3c/master/mipi-i3c-hci/core.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c
> index 3a3a9a3d4dec..e80aa1f5722e 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/core.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/core.c
> @@ -1189,11 +1189,14 @@ static const struct acpi_device_id i3c_hci_acpi_match[] = {
>  MODULE_DEVICE_TABLE(acpi, i3c_hci_acpi_match);
>  
>  static const struct platform_device_id i3c_hci_driver_ids[] = {
> -	{ .name = "intel-lpss-i3c", HCI_QUIRK_RPM_ALLOWED |
> -				    HCI_QUIRK_RPM_IBI_ALLOWED |
> -				    HCI_QUIRK_RPM_PARENT_MANAGED |
> -				    HCI_QUIRK_DMA_ABORT_REQUIRES_PIO_RESET |
> -				    HCI_QUIRK_DMA_REQUIRES_HC_ABORT },
> +	{
> +		.name = "intel-lpss-i3c",
> +		.driver_data = HCI_QUIRK_RPM_ALLOWED |
> +			HCI_QUIRK_RPM_IBI_ALLOWED |
> +			HCI_QUIRK_RPM_PARENT_MANAGED |
> +			HCI_QUIRK_DMA_ABORT_REQUIRES_PIO_RESET |
> +			HCI_QUIRK_DMA_REQUIRES_HC_ABORT,
> +	},
>  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(platform, i3c_hci_driver_ids);
> 
> base-commit: 8d6dbbbe3ba62de0a63e962ee004afb848c8e3ac

Re: [PATCH v1] i3c: mipi-i3c-hci: Use named initializers for platform_device_id's .driver_data

[Frank Li]

On Tue, Jun 16, 2026 at 04:34:20PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> The assignment in this driver uses a mixed way to initialize the
> platform_device_id array. .name is assigned by name and .driver_data by
> position. Unify that to use named assignment for both struct members.
> This is needed for a planned change to struct platform_device_id
> replacing .driver_data by an anonymous union.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/i3c/master/mipi-i3c-hci/core.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c
> index 3a3a9a3d4dec..e80aa1f5722e 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/core.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/core.c
> @@ -1189,11 +1189,14 @@ static const struct acpi_device_id i3c_hci_acpi_match[] = {
>  MODULE_DEVICE_TABLE(acpi, i3c_hci_acpi_match);
>
>  static const struct platform_device_id i3c_hci_driver_ids[] = {
> -	{ .name = "intel-lpss-i3c", HCI_QUIRK_RPM_ALLOWED |
> -				    HCI_QUIRK_RPM_IBI_ALLOWED |
> -				    HCI_QUIRK_RPM_PARENT_MANAGED |
> -				    HCI_QUIRK_DMA_ABORT_REQUIRES_PIO_RESET |
> -				    HCI_QUIRK_DMA_REQUIRES_HC_ABORT },
> +	{
> +		.name = "intel-lpss-i3c",
> +		.driver_data = HCI_QUIRK_RPM_ALLOWED |
> +			HCI_QUIRK_RPM_IBI_ALLOWED |
> +			HCI_QUIRK_RPM_PARENT_MANAGED |
> +			HCI_QUIRK_DMA_ABORT_REQUIRES_PIO_RESET |
> +			HCI_QUIRK_DMA_REQUIRES_HC_ABORT,
> +	},
>  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(platform, i3c_hci_driver_ids);
>
> base-commit: 8d6dbbbe3ba62de0a63e962ee004afb848c8e3ac
> --
> 2.47.3
>

Re: [PATCH v1] i3c: mipi-i3c-hci: Use named initializers for platform_device_id's .driver_data

[Alexandre Belloni]

On Tue, 16 Jun 2026 16:34:20 +0200, Uwe Kleine-König (The Capable Hub) wrote:
> The assignment in this driver uses a mixed way to initialize the
> platform_device_id array. .name is assigned by name and .driver_data by
> position. Unify that to use named assignment for both struct members.
> This is needed for a planned change to struct platform_device_id
> replacing .driver_data by an anonymous union.
> 
> 
> [...]

Applied, thanks!

[1/1] i3c: mipi-i3c-hci: Use named initializers for platform_device_id's .driver_data
      https://git.kernel.org/i3c/c/678e9409dd78

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com