From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvmem: core: switch to device_property_present for reading property "read-only"
Date: Sat, 25 Nov 2017 14:51:21 +0000 [thread overview]
Message-ID: <0906195e-0143-991d-7007-56012ddd4729@linaro.org> (raw)
In-Reply-To: <02db961d-4293-8d67-431f-5bbfc97acc84@gmail.com>
Thanks for the patch,
On 25/11/17 11:56, Heiner Kallweit wrote:
> Switch to more generic device_property_present to consider also non-DT
> properties.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/nvmem/core.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
It looks good for me, I will queue it up!
> index 5a5cefd12..ba0e3b453 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -444,7 +444,6 @@ static int nvmem_setup_compat(struct nvmem_device *nvmem,
> struct nvmem_device *nvmem_register(const struct nvmem_config *config)
> {
> struct nvmem_device *nvmem;
> - struct device_node *np;
> int rval;
>
> if (!config->dev)
> @@ -473,13 +472,12 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
> nvmem->priv = config->priv;
> nvmem->reg_read = config->reg_read;
> nvmem->reg_write = config->reg_write;
> - np = config->dev->of_node;
> - nvmem->dev.of_node = np;
> + nvmem->dev.of_node = config->dev->of_node;
> dev_set_name(&nvmem->dev, "%s%d",
> config->name ? : "nvmem",
> config->name ? config->id : nvmem->id);
>
> - nvmem->read_only = of_property_read_bool(np, "read-only") |
> + nvmem->read_only = device_property_present(config->dev, "read-only") |
> config->read_only;
>
> if (config->root_only)
>
prev parent reply other threads:[~2017-11-25 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-25 11:56 Heiner Kallweit
2017-11-25 14:51 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0906195e-0143-991d-7007-56012ddd4729@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®