mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] i3c: renesas: Fix MDYAD(x) field length
@ 2026-10-01 15:10 Diogo Ivo
  2026-10-01 15:17 ` Frank Li
  2026-10-02  8:47 ` Claudiu Beznea
  0 siblings, 2 replies; 3+ messages in thread
From: Diogo Ivo @ 2026-10-01 15:10 UTC (permalink / raw)
  To: Wolfram Sang, Tommaso Merciai, Alexandre Belloni, Frank Li
  Cc: linux-i3c, linux-kernel, stable, Diogo Ivo

Fix the length of the MDYAD(x) macro to be 7 bits as it represents an
I3C address, which is 7 bits. The length of this field was confirmed on
the documentation of the RZ/G3{E,L,S} SoCs.

Fixes: d028219a9f148 ("i3c: master: Add basic driver for the Renesas I3C controller")
Cc: stable@vger.kernel.org
Signed-off-by: Diogo Ivo <diogo.ivo.sx@renesas.com>
---
 drivers/i3c/master/renesas-i3c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-i3c.c
index 28c0927a0179..8b264f72e55c 100644
--- a/drivers/i3c/master/renesas-i3c.c
+++ b/drivers/i3c/master/renesas-i3c.c
@@ -37,7 +37,7 @@
 #define  BCTL_BUSE             BIT(31)

 #define MSDVAD                 0x18
-#define  MSDVAD_MDYAD(x)       FIELD_PREP(GENMASK(21, 16), x)
+#define  MSDVAD_MDYAD(x)       FIELD_PREP(GENMASK(22, 16), x)
 #define  MSDVAD_MDYADV         BIT(31)

 #define RSTCTL                 0x20

---
base-commit: 66b734f67a4a0a4c2313afb89033d5ab8b8f7523
change-id: 20261001-divo-ssgrlpcsrc-2966-i3c_mdyad-0ba701c9add9

Best regards,
--
Diogo Ivo <diogo.ivo.sx@renesas.com>

________________________________

Renesas Electronics Europe GmbH
Registered Office: Arcadiastrasse 10
DE-40472 Duesseldorf
Commercial Registry: Duesseldorf, HRB 3708
Managing Director: Carsten Jauch
VAT-No.: DE 14978647
Tax-ID-No: 105/5839/1793

Legal Disclaimer: This e-mail communication (and any attachment/s) is confidential and contains proprietary information, some or all of which may be legally privileged. It is intended solely for the use of the individual or entity to which it is addressed. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and may be unlawful.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] i3c: renesas: Fix MDYAD(x) field length
  2026-10-01 15:10 [PATCH] i3c: renesas: Fix MDYAD(x) field length Diogo Ivo
@ 2026-10-01 15:17 ` Frank Li
  2026-10-02  8:47 ` Claudiu Beznea
  1 sibling, 0 replies; 3+ messages in thread
From: Frank Li @ 2026-10-01 15:17 UTC (permalink / raw)
  To: Diogo Ivo
  Cc: Wolfram Sang, Tommaso Merciai, Alexandre Belloni, Frank Li,
	linux-i3c, linux-kernel, stable

On Thu, Oct 01, 2026 at 04:10:09PM +0100, Diogo Ivo wrote:
> Fix the length of the MDYAD(x) macro to be 7 bits as it represents an
> I3C address, which is 7 bits. The length of this field was confirmed on
> the documentation of the RZ/G3{E,L,S} SoCs.
>
> Fixes: d028219a9f148 ("i3c: master: Add basic driver for the Renesas I3C controller")
> Cc: stable@vger.kernel.org
> Signed-off-by: Diogo Ivo <diogo.ivo.sx@renesas.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/i3c/master/renesas-i3c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-i3c.c
> index 28c0927a0179..8b264f72e55c 100644
> --- a/drivers/i3c/master/renesas-i3c.c
> +++ b/drivers/i3c/master/renesas-i3c.c
> @@ -37,7 +37,7 @@
>  #define  BCTL_BUSE             BIT(31)
>
>  #define MSDVAD                 0x18
> -#define  MSDVAD_MDYAD(x)       FIELD_PREP(GENMASK(21, 16), x)
> +#define  MSDVAD_MDYAD(x)       FIELD_PREP(GENMASK(22, 16), x)
>  #define  MSDVAD_MDYADV         BIT(31)
>
>  #define RSTCTL                 0x20
>
> ---
> base-commit: 66b734f67a4a0a4c2313afb89033d5ab8b8f7523
> change-id: 20261001-divo-ssgrlpcsrc-2966-i3c_mdyad-0ba701c9add9
>
> Best regards,
> --
> Diogo Ivo <diogo.ivo.sx@renesas.com>
>
> ________________________________
>
> Renesas Electronics Europe GmbH
> Registered Office: Arcadiastrasse 10
> DE-40472 Duesseldorf
> Commercial Registry: Duesseldorf, HRB 3708
> Managing Director: Carsten Jauch
> VAT-No.: DE 14978647
> Tax-ID-No: 105/5839/1793
>
> Legal Disclaimer: This e-mail communication (and any attachment/s) is confidential and contains proprietary information, some or all of which may be legally privileged. It is intended solely for the use of the individual or entity to which it is addressed. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and may be unlawful.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] i3c: renesas: Fix MDYAD(x) field length
  2026-10-01 15:10 [PATCH] i3c: renesas: Fix MDYAD(x) field length Diogo Ivo
  2026-10-01 15:17 ` Frank Li
@ 2026-10-02  8:47 ` Claudiu Beznea
  1 sibling, 0 replies; 3+ messages in thread
From: Claudiu Beznea @ 2026-10-02  8:47 UTC (permalink / raw)
  To: Diogo Ivo, Wolfram Sang, Tommaso Merciai, Alexandre Belloni, Frank Li
  Cc: linux-i3c, linux-kernel, stable



On 10/1/26 18:10, Diogo Ivo wrote:
> Fix the length of the MDYAD(x) macro to be 7 bits as it represents an
> I3C address, which is 7 bits. The length of this field was confirmed on
> the documentation of the RZ/G3{E,L,S} SoCs.
> 
> Fixes: d028219a9f148 ("i3c: master: Add basic driver for the Renesas I3C controller")
> Cc:stable@vger.kernel.org
> Signed-off-by: Diogo Ivo<diogo.ivo.sx@renesas.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-10-02  8:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-01 15:10 [PATCH] i3c: renesas: Fix MDYAD(x) field length Diogo Ivo
2026-10-01 15:17 ` Frank Li
2026-10-02  8:47 ` Claudiu Beznea

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®