mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Olliver Schinagl <oliver@schinagl.nl>
To: Andrew Lunn <andrew@lunn.ch>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	"Gustavo A . R . Silva" <gustavoars@kernel.org>,
	Alexandru Tachici <alexandru.tachici@analog.com>,
	Hao Chen <chenhao288@hisilicon.com>,
	Olliver Schinagl <oliver+list@schinagl.nl>,
	"David S . Miller" <davem@davemloft.net>,
	Ido Schimmel <idosch@nvidia.com>,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH] linkstate: Add macros for link state up/down
Date: Tue, 6 Sep 2022 16:57:28 +0200	[thread overview]
Message-ID: <098a4abd-32fa-ce02-7d6d-aa3db6c7fceb@schinagl.nl> (raw)
In-Reply-To: <Yxc6o+6u2zlPxU3a@lunn.ch>

Hey Andrew,

On 06-09-2022 14:18, Andrew Lunn wrote:
> On Tue, Sep 06, 2022 at 10:37:54AM +0200, Olliver Schinagl wrote:
>> The phylink_link_state.state property can be up or down, via 1 and 0.
>>
>> The other link state's (speed, duplex) are defined in ethtool.h so lets
>> add defines for the link-state there as well so we can use macro's to
>> define our up/down states.
> Hi Olliver
>
> The change itself is fine, but we don't add to the API without
> users. Please make use of these two new values somewhere, to show they
> are really useful.
>
>      Andrew

So I've found quite a lot of users, which I suppose is good. I've since 
decided to turn it into an enum, and refer in the structs as `enum 
phy_linkstate link:1` (is this even legal?) Would that ok for v2?


Olliver


      parent reply	other threads:[~2022-09-06 15:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-06  8:37 Olliver Schinagl
2022-09-06 12:18 ` Andrew Lunn
2022-09-06 13:38   ` Olliver Schinagl
2022-09-06 14:57   ` Olliver Schinagl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=098a4abd-32fa-ce02-7d6d-aa3db6c7fceb@schinagl.nl \
    --to=oliver@schinagl.nl \
    --cc=alexandru.tachici@analog.com \
    --cc=andrew@lunn.ch \
    --cc=chenhao288@hisilicon.com \
    --cc=davem@davemloft.net \
    --cc=gustavoars@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oliver+list@schinagl.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®