From: Andrew Lunn <andrew@lunn.ch>
To: Olliver Schinagl <oliver@schinagl.nl>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
Alexandru Tachici <alexandru.tachici@analog.com>,
Hao Chen <chenhao288@hisilicon.com>,
Olliver Schinagl <oliver+list@schinagl.nl>,
"David S . Miller" <davem@davemloft.net>,
Ido Schimmel <idosch@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH] linkstate: Add macros for link state up/down
Date: Tue, 6 Sep 2022 14:18:43 +0200 [thread overview]
Message-ID: <Yxc6o+6u2zlPxU3a@lunn.ch> (raw)
In-Reply-To: <20220906083754.2183092-1-oliver@schinagl.nl>
On Tue, Sep 06, 2022 at 10:37:54AM +0200, Olliver Schinagl wrote:
> The phylink_link_state.state property can be up or down, via 1 and 0.
>
> The other link state's (speed, duplex) are defined in ethtool.h so lets
> add defines for the link-state there as well so we can use macro's to
> define our up/down states.
Hi Olliver
The change itself is fine, but we don't add to the API without
users. Please make use of these two new values somewhere, to show they
are really useful.
Andrew
next prev parent reply other threads:[~2022-09-06 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 8:37 Olliver Schinagl
2022-09-06 12:18 ` Andrew Lunn [this message]
2022-09-06 13:38 ` Olliver Schinagl
2022-09-06 14:57 ` Olliver Schinagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yxc6o+6u2zlPxU3a@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandru.tachici@analog.com \
--cc=chenhao288@hisilicon.com \
--cc=davem@davemloft.net \
--cc=gustavoars@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver+list@schinagl.nl \
--cc=oliver@schinagl.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®