From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "'Minchan Kim'" <minchan@kernel.org>,
"'Andrew Morton'" <akpm@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
<kernel-team@lge.com>, "'Johannes Weiner'" <hannes@cmpxchg.org>,
"'Michal Hocko'" <mhocko@suse.com>,
"'Kirill A. Shutemov'" <kirill.shutemov@linux.intel.com>,
"'Anshuman Khandual'" <khandual@linux.vnet.ibm.com>
Subject: Re: [PATCH v1 01/10] mm: remove unncessary ret in page_referenced
Date: Mon, 13 Mar 2017 14:23:12 +0800 [thread overview]
Message-ID: <099101d29bc2$4aef6790$e0ce36b0$@alibaba-inc.com> (raw)
In-Reply-To: <1489365353-28205-2-git-send-email-minchan@kernel.org>
On March 13, 2017 8:36 AM Minchan Kim wrote:
>
> Anyone doesn't use ret variable. Remove it.
>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Signed-off-by: Minchan Kim <minchan@kernel.org>
> ---
Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>
> mm/rmap.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/rmap.c b/mm/rmap.c
> index 7d24bb9..9dbfa6f 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -807,7 +807,6 @@ int page_referenced(struct page *page,
> struct mem_cgroup *memcg,
> unsigned long *vm_flags)
> {
> - int ret;
> int we_locked = 0;
> struct page_referenced_arg pra = {
> .mapcount = total_mapcount(page),
> @@ -841,7 +840,7 @@ int page_referenced(struct page *page,
> rwc.invalid_vma = invalid_page_referenced_vma;
> }
>
> - ret = rmap_walk(page, &rwc);
> + rmap_walk(page, &rwc);
> *vm_flags = pra.vm_flags;
>
> if (we_locked)
> --
> 2.7.4
next prev parent reply other threads:[~2017-03-13 6:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 0:35 [PATCH v1 00/10] make try_to_unmap simple Minchan Kim
2017-03-13 0:35 ` [PATCH v1 01/10] mm: remove unncessary ret in page_referenced Minchan Kim
2017-03-13 6:23 ` Hillf Danton [this message]
2017-03-13 0:35 ` [PATCH v1 02/10] mm: remove SWAP_DIRTY in ttu Minchan Kim
2017-03-13 6:34 ` Hillf Danton
2017-03-14 7:34 ` Minchan Kim
2017-03-13 0:35 ` [PATCH v1 03/10] mm: remove SWAP_MLOCK check for SWAP_SUCCESS " Minchan Kim
2017-03-13 0:35 ` [PATCH v1 04/10] mm: make the try_to_munlock void function Minchan Kim
2017-03-13 0:35 ` [PATCH v1 05/10] mm: remove SWAP_MLOCK in ttu Minchan Kim
2017-03-13 0:35 ` [PATCH v1 06/10] mm: remove SWAP_AGAIN " Minchan Kim
2017-03-13 0:35 ` [PATCH v1 07/10] mm: make ttu's return boolean Minchan Kim
2017-03-13 0:35 ` [PATCH v1 08/10] mm: make rmap_walk void function Minchan Kim
2017-03-13 0:35 ` [PATCH v1 09/10] mm: make rmap_one boolean function Minchan Kim
2017-03-13 19:45 ` Andrew Morton
2017-03-14 7:37 ` Minchan Kim
2017-03-13 0:35 ` [PATCH v1 10/10] mm: remove SWAP_[SUCCESS|AGAIN|FAIL] Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='099101d29bc2$4aef6790$e0ce36b0$@alibaba-inc.com' \
--to=hillf.zj@alibaba-inc.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@lge.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome