From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
<kernel-team@lge.com>, Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>
Subject: Re: [PATCH v1 09/10] mm: make rmap_one boolean function
Date: Mon, 13 Mar 2017 12:45:00 -0700 [thread overview]
Message-ID: <20170313124500.ffc91fa4d4077719928e3274@linux-foundation.org> (raw)
In-Reply-To: <1489365353-28205-10-git-send-email-minchan@kernel.org>
On Mon, 13 Mar 2017 09:35:52 +0900 Minchan Kim <minchan@kernel.org> wrote:
> rmap_one's return value controls whether rmap_work should contine to
> scan other ptes or not so it's target for changing to boolean.
> Return true if the scan should be continued. Otherwise, return false
> to stop the scanning.
>
> This patch makes rmap_one's return value to boolean.
"SWAP_AGAIN" conveys meaning to the reader, whereas the meaning of
"true" is unclear. So it would be better to document the return value
of these functions.
next prev parent reply other threads:[~2017-03-13 19:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 0:35 [PATCH v1 00/10] make try_to_unmap simple Minchan Kim
2017-03-13 0:35 ` [PATCH v1 01/10] mm: remove unncessary ret in page_referenced Minchan Kim
2017-03-13 6:23 ` Hillf Danton
2017-03-13 0:35 ` [PATCH v1 02/10] mm: remove SWAP_DIRTY in ttu Minchan Kim
2017-03-13 6:34 ` Hillf Danton
2017-03-14 7:34 ` Minchan Kim
2017-03-13 0:35 ` [PATCH v1 03/10] mm: remove SWAP_MLOCK check for SWAP_SUCCESS " Minchan Kim
2017-03-13 0:35 ` [PATCH v1 04/10] mm: make the try_to_munlock void function Minchan Kim
2017-03-13 0:35 ` [PATCH v1 05/10] mm: remove SWAP_MLOCK in ttu Minchan Kim
2017-03-13 0:35 ` [PATCH v1 06/10] mm: remove SWAP_AGAIN " Minchan Kim
2017-03-13 0:35 ` [PATCH v1 07/10] mm: make ttu's return boolean Minchan Kim
2017-03-13 0:35 ` [PATCH v1 08/10] mm: make rmap_walk void function Minchan Kim
2017-03-13 0:35 ` [PATCH v1 09/10] mm: make rmap_one boolean function Minchan Kim
2017-03-13 19:45 ` Andrew Morton [this message]
2017-03-14 7:37 ` Minchan Kim
2017-03-13 0:35 ` [PATCH v1 10/10] mm: remove SWAP_[SUCCESS|AGAIN|FAIL] Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313124500.ffc91fa4d4077719928e3274@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@lge.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®