mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hoegeun Kwon <hoegeun.kwon@samsung.com>
To: Inki Dae <inki.dae@samsung.com>,
	jy0922.shim@samsung.com, sw0312.kim@samsung.com,
	airlied@linux.ie, kgene@kernel.org, krzk@kernel.org
Cc: javier@osg.samsung.com, a.hajda@samsung.com,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hoegeun Kwon <hoegeun.kwon@samsung.com>
Subject: Re: [PATCH] drm/exynos/dsi: Remove error handling for bridge_node DT parsing
Date: Tue, 13 Jun 2017 19:33:28 +0900	[thread overview]
Message-ID: <099ebbf8-4ec2-be45-f1d7-36bf24def429@samsung.com> (raw)
In-Reply-To: <593FAF9E.1040406@samsung.com>

On 06/13/2017 06:25 PM, Inki Dae wrote:
>
> 2017년 06월 09일 18:23에 Hoegeun Kwon 이(가) 쓴 글:
>> The bridge_node is unnecessary between FIMD and DSIM. If don't remove
>> error handling, it will not work between FIMD and DSIM. So remove
>> error handling.
> Please make sure to describe why bridge_node is unnecessary.
> For example,
> In case of Exynos SoC, a bridge device such as mDNIe and MIC could be placed between Display Controller and MIPI DSI device but the bridge device is required optionally.
>
> Thanks,
> Inki Dae

Remove the error handling for bridge_node because the bridge_node is
required optionally. It has already been described in commit message.

For example,
In case of Exynos 3250 SoC, no bridge_node is required between FIMD
and MIPI DSI.

Best regards,
Hoegeun

>
>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
>> ---
>>   drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>> index a11b795..6ee0dac 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>> @@ -1651,8 +1651,6 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi)
>>   		return ret;
>>   
>>   	dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0);
>> -	if (!dsi->bridge_node)
>> -		return -EINVAL;
>>   
>>   	return 0;
>>   }
>>
>

      reply	other threads:[~2017-06-13 10:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170609092307epcas5p3a7851f80bd799626782941a640824521@epcas5p3.samsung.com>
2017-06-09  9:23 ` Hoegeun Kwon
2017-06-13  9:25   ` Inki Dae
2017-06-13 10:33     ` Hoegeun Kwon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=099ebbf8-4ec2-be45-f1d7-36bf24def429@samsung.com \
    --to=hoegeun.kwon@samsung.com \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=inki.dae@samsung.com \
    --cc=javier@osg.samsung.com \
    --cc=jy0922.shim@samsung.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=sw0312.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®