* [PATCH v5] ata: pata_arasan_cf: Use dev_err_probe() instead dev_err() in data_xfer()
@ 2023-07-25 3:06 Minjie Du
2023-07-25 4:21 ` Viresh Kumar
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Minjie Du @ 2023-07-25 3:06 UTC (permalink / raw)
To: Viresh Kumar, Sergey Shtylyov, Damien Le Moal,
open list:LIBATA PATA ARASAN COMPACT FLASH CONTROLLER, open list
Cc: opensource.kernel, Minjie Du
It is possible for dma_request_chan() to return EPROBE_DEFER, which means
acdev->host->dev is not ready yet.
At this point dev_err() will have no output.
Signed-off-by: Minjie Du <duminjie@vivo.com>
---
V2 -> V5: Fixed code formatting errors.
---
drivers/ata/pata_arasan_cf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
index 6ab294322e79..b32d47112c0a 100644
--- a/drivers/ata/pata_arasan_cf.c
+++ b/drivers/ata/pata_arasan_cf.c
@@ -529,7 +529,8 @@ static void data_xfer(struct work_struct *work)
/* dma_request_channel may sleep, so calling from process context */
acdev->dma_chan = dma_request_chan(acdev->host->dev, "data");
if (IS_ERR(acdev->dma_chan)) {
- dev_err(acdev->host->dev, "Unable to get dma_chan\n");
+ dev_err_probe(acdev->host->dev, PTR_ERR(acdev->dma_chan),
+ "Unable to get dma_chan\n");
acdev->dma_chan = NULL;
goto chan_request_fail;
}
--
2.39.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v5] ata: pata_arasan_cf: Use dev_err_probe() instead dev_err() in data_xfer()
2023-07-25 3:06 [PATCH v5] ata: pata_arasan_cf: Use dev_err_probe() instead dev_err() in data_xfer() Minjie Du
@ 2023-07-25 4:21 ` Viresh Kumar
2023-07-25 9:51 ` Sergey Shtylyov
2023-07-25 23:35 ` Damien Le Moal
2 siblings, 0 replies; 4+ messages in thread
From: Viresh Kumar @ 2023-07-25 4:21 UTC (permalink / raw)
To: Minjie Du
Cc: Viresh Kumar, Sergey Shtylyov, Damien Le Moal,
open list:LIBATA PATA ARASAN COMPACT FLASH CONTROLLER, open list,
opensource.kernel
On 25-07-23, 11:06, Minjie Du wrote:
> It is possible for dma_request_chan() to return EPROBE_DEFER, which means
> acdev->host->dev is not ready yet.
> At this point dev_err() will have no output.
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
> V2 -> V5: Fixed code formatting errors.
> ---
> drivers/ata/pata_arasan_cf.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
> index 6ab294322e79..b32d47112c0a 100644
> --- a/drivers/ata/pata_arasan_cf.c
> +++ b/drivers/ata/pata_arasan_cf.c
> @@ -529,7 +529,8 @@ static void data_xfer(struct work_struct *work)
> /* dma_request_channel may sleep, so calling from process context */
> acdev->dma_chan = dma_request_chan(acdev->host->dev, "data");
> if (IS_ERR(acdev->dma_chan)) {
> - dev_err(acdev->host->dev, "Unable to get dma_chan\n");
> + dev_err_probe(acdev->host->dev, PTR_ERR(acdev->dma_chan),
> + "Unable to get dma_chan\n");
> acdev->dma_chan = NULL;
> goto chan_request_fail;
> }
Missed it last time, but the formatting looks okay now I guess.
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v5] ata: pata_arasan_cf: Use dev_err_probe() instead dev_err() in data_xfer()
2023-07-25 3:06 [PATCH v5] ata: pata_arasan_cf: Use dev_err_probe() instead dev_err() in data_xfer() Minjie Du
2023-07-25 4:21 ` Viresh Kumar
@ 2023-07-25 9:51 ` Sergey Shtylyov
2023-07-25 23:35 ` Damien Le Moal
2 siblings, 0 replies; 4+ messages in thread
From: Sergey Shtylyov @ 2023-07-25 9:51 UTC (permalink / raw)
To: Minjie Du, Viresh Kumar, Damien Le Moal,
open list:LIBATA PATA ARASAN COMPACT FLASH CONTROLLER, open list
Cc: opensource.kernel
On 7/25/23 6:06 AM, Minjie Du wrote:
> It is possible for dma_request_chan() to return EPROBE_DEFER, which means
> acdev->host->dev is not ready yet.
> At this point dev_err() will have no output.
It will, else the patch wouldn't have been needed, right?
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
> V2 -> V5: Fixed code formatting errors.
> ---
> drivers/ata/pata_arasan_cf.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
> index 6ab294322e79..b32d47112c0a 100644
> --- a/drivers/ata/pata_arasan_cf.c
> +++ b/drivers/ata/pata_arasan_cf.c
> @@ -529,7 +529,8 @@ static void data_xfer(struct work_struct *work)
> /* dma_request_channel may sleep, so calling from process context */
> acdev->dma_chan = dma_request_chan(acdev->host->dev, "data");
> if (IS_ERR(acdev->dma_chan)) {
> - dev_err(acdev->host->dev, "Unable to get dma_chan\n");
> + dev_err_probe(acdev->host->dev, PTR_ERR(acdev->dma_chan),
> + "Unable to get dma_chan\n");
> acdev->dma_chan = NULL;
> goto chan_request_fail;
> }
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v5] ata: pata_arasan_cf: Use dev_err_probe() instead dev_err() in data_xfer()
2023-07-25 3:06 [PATCH v5] ata: pata_arasan_cf: Use dev_err_probe() instead dev_err() in data_xfer() Minjie Du
2023-07-25 4:21 ` Viresh Kumar
2023-07-25 9:51 ` Sergey Shtylyov
@ 2023-07-25 23:35 ` Damien Le Moal
2 siblings, 0 replies; 4+ messages in thread
From: Damien Le Moal @ 2023-07-25 23:35 UTC (permalink / raw)
To: Minjie Du, Viresh Kumar, Sergey Shtylyov,
open list:LIBATA PATA ARASAN COMPACT FLASH CONTROLLER, open list
Cc: opensource.kernel
On 7/25/23 12:06, Minjie Du wrote:
> It is possible for dma_request_chan() to return EPROBE_DEFER, which means
> acdev->host->dev is not ready yet.
> At this point dev_err() will have no output.
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
Applied to for-6.5-fixes. Thanks !
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-25 23:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-25 3:06 [PATCH v5] ata: pata_arasan_cf: Use dev_err_probe() instead dev_err() in data_xfer() Minjie Du
2023-07-25 4:21 ` Viresh Kumar
2023-07-25 9:51 ` Sergey Shtylyov
2023-07-25 23:35 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®