Re: [PATCH v3 6/8] ref_tracker: widen the ref_tracker_dir.name field

[Andrew Lunn <andrew@lunn.ch>]

On Thu, Apr 17, 2025 at 05:27:05PM -0400, Jeff Layton wrote:
> On Thu, 2025-04-17 at 21:29 +0200, Andrew Lunn wrote:
> > On Thu, Apr 17, 2025 at 09:11:09AM -0400, Jeff Layton wrote:
> > > Currently it's 32 bytes, but with the need to move to unique names for
> > > debugfs files, that won't be enough. Move to a 64 byte name field.
> > > 
> > > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > 
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> > 
> 
> 
> Thanks for the review!
> 
> It occurs to me that we don't technically need this patch, since
> ref_tracker_dir_debugfs() doesn't overwrite dir->name in this version.

I had not noticed that. I don't know if that is good or bad. Two
different names for the same thing. Nice thing is, this is debugfs, so
we are not setting an ABI. We can change this any time we want.

> Perhaps we should drop this patch, or I could define the
> REF_TRACKER_NAMESZ constant and just leave it at 32?

Having the constant might make future changes easier to make, avoid
having to find the hard coded 32.

	Andrew