From: Jeff Layton <jlayton@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Qasim Ijaz <qasdev00@gmail.com>,
Nathan Chancellor <nathan@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3 6/8] ref_tracker: widen the ref_tracker_dir.name field
Date: Thu, 17 Apr 2025 17:27:05 -0400 [thread overview]
Message-ID: <c635c6024a18e9a3bd1f3832521f1976377fe314.camel@kernel.org> (raw)
In-Reply-To: <6ad1f1ae-a912-43ec-aac5-de49e344e9ff@lunn.ch>
On Thu, 2025-04-17 at 21:29 +0200, Andrew Lunn wrote:
> On Thu, Apr 17, 2025 at 09:11:09AM -0400, Jeff Layton wrote:
> > Currently it's 32 bytes, but with the need to move to unique names for
> > debugfs files, that won't be enough. Move to a 64 byte name field.
> >
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
Thanks for the review!
It occurs to me that we don't technically need this patch, since
ref_tracker_dir_debugfs() doesn't overwrite dir->name in this version.
Perhaps we should drop this patch, or I could define the
REF_TRACKER_NAMESZ constant and just leave it at 32?
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2025-04-17 21:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 13:11 [PATCH v3 0/8] ref_tracker: add ability to register a debugfs file for a ref_tracker_dir Jeff Layton
2025-04-17 13:11 ` [PATCH v3 1/8] ref_tracker: don't use %pK in pr_ostream() output Jeff Layton
2025-04-17 13:25 ` Thomas Weißschuh
2025-04-17 13:11 ` [PATCH v3 2/8] ref_tracker: add a top level debugfs directory for ref_tracker Jeff Layton
2025-04-17 19:24 ` Andrew Lunn
2025-04-17 13:11 ` [PATCH v3 3/8] ref_tracker: have callers pass output function to pr_ostream() Jeff Layton
2025-04-17 19:26 ` Andrew Lunn
2025-04-17 13:11 ` [PATCH v3 4/8] ref_tracker: allow pr_ostream() to print directly to a seq_file Jeff Layton
2025-04-17 19:27 ` Andrew Lunn
2025-04-17 13:11 ` [PATCH v3 5/8] ref_tracker: add ability to register a file in debugfs for a ref_tracker_dir Jeff Layton
2025-04-17 19:29 ` Andrew Lunn
2025-04-17 13:11 ` [PATCH v3 6/8] ref_tracker: widen the ref_tracker_dir.name field Jeff Layton
2025-04-17 19:29 ` Andrew Lunn
2025-04-17 21:27 ` Jeff Layton [this message]
2025-04-17 21:54 ` Andrew Lunn
2025-04-17 13:11 ` [PATCH v3 7/8] net: add ref_tracker_dir_debugfs() calls for netns refcount tracking Jeff Layton
2025-04-17 19:30 ` Andrew Lunn
2025-04-17 13:11 ` [PATCH v3 8/8] net: register debugfs file for net_device refcnt tracker Jeff Layton
2025-04-17 19:31 ` Andrew Lunn
2025-04-17 21:17 ` Kuniyuki Iwashima
2025-04-17 19:32 ` [PATCH v3 0/8] ref_tracker: add ability to register a debugfs file for a ref_tracker_dir Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c635c6024a18e9a3bd1f3832521f1976377fe314.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qasdev00@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®