From: Like Xu <like.xu.linux@gmail.com>
To: "Paolo Bonzini - Distinguished Engineer (kernel-recipes.org)
(KVM HoF)" <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, seanjc@google.com,
David Dunn <daviddunn@google.com>,
Jim Mattson <jmattson@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Joerg Roedel <joro@8bytes.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/3] KVM: x86: Provide per VM capability for disabling PMU virtualization
Date: Wed, 9 Feb 2022 18:33:00 +0800 [thread overview]
Message-ID: <09d8b472-000b-7150-f60d-ffb5706b164e@gmail.com> (raw)
In-Reply-To: <CALMp9eSuavLEJ0_jwuOgmSX+Y8iJLsJT0xkGfMZg6B7kGyDmBQ@mail.gmail.com>
cc LKML and full list of KVM reviewers.
On 25/1/2022 2:39 am, Jim Mattson wrote:
> On Sun, Jan 23, 2022 at 10:45 AM David Dunn <daviddunn@google.com> wrote:
>>
>> KVM_CAP_PMU_DISABLE is used to disable PMU virtualization on individual
>> x86 VMs. PMU configuration must be done prior to creating VCPUs.
>>
>> To enable future extension, KVM_CAP_PMU_CAPABILITY reports available
>> settings via bitmask when queried via check_extension.
>>
>> For VMs that have PMU virtualization disabled, usermode will need to
>> clear CPUID leaf 0xA to notify guests.
>>
>> Signed-off-by: David Dunn <daviddunn@google.com>
>
> Nit: The two references to CPUID leaf 0xA should be qualified as
> applying only to Intel VMs.
>
> Reviewed-by: Jim Mattson <jmattson@google.com>
>
Nit: It looks like we already have "#define KVM_CAP_SYS_ATTRIBUTES 209".
Hope it helps a little:
Reviewed-by: Like Xu <likexu@tencent.com>
next parent reply other threads:[~2022-02-09 10:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220123184541.993212-1-daviddunn@google.com>
[not found] ` <20220123184541.993212-2-daviddunn@google.com>
[not found] ` <CALMp9eSuavLEJ0_jwuOgmSX+Y8iJLsJT0xkGfMZg6B7kGyDmBQ@mail.gmail.com>
2022-02-09 10:33 ` Like Xu [this message]
2022-02-09 17:30 ` David Dunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09d8b472-000b-7150-f60d-ffb5706b164e@gmail.com \
--to=like.xu.linux@gmail.com \
--cc=daviddunn@google.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®