* Re: [PATCH v5 1/3] KVM: x86: Provide per VM capability for disabling PMU virtualization
[not found] ` <CALMp9eSuavLEJ0_jwuOgmSX+Y8iJLsJT0xkGfMZg6B7kGyDmBQ@mail.gmail.com>
@ 2022-02-09 10:33 ` Like Xu
2022-02-09 17:30 ` David Dunn
0 siblings, 1 reply; 2+ messages in thread
From: Like Xu @ 2022-02-09 10:33 UTC (permalink / raw)
To: Paolo Bonzini - Distinguished Engineer (kernel-recipes.org) (KVM HoF)
Cc: kvm, seanjc, David Dunn, Jim Mattson, Vitaly Kuznetsov,
Wanpeng Li, Joerg Roedel, linux-kernel
cc LKML and full list of KVM reviewers.
On 25/1/2022 2:39 am, Jim Mattson wrote:
> On Sun, Jan 23, 2022 at 10:45 AM David Dunn <daviddunn@google.com> wrote:
>>
>> KVM_CAP_PMU_DISABLE is used to disable PMU virtualization on individual
>> x86 VMs. PMU configuration must be done prior to creating VCPUs.
>>
>> To enable future extension, KVM_CAP_PMU_CAPABILITY reports available
>> settings via bitmask when queried via check_extension.
>>
>> For VMs that have PMU virtualization disabled, usermode will need to
>> clear CPUID leaf 0xA to notify guests.
>>
>> Signed-off-by: David Dunn <daviddunn@google.com>
>
> Nit: The two references to CPUID leaf 0xA should be qualified as
> applying only to Intel VMs.
>
> Reviewed-by: Jim Mattson <jmattson@google.com>
>
Nit: It looks like we already have "#define KVM_CAP_SYS_ATTRIBUTES 209".
Hope it helps a little:
Reviewed-by: Like Xu <likexu@tencent.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v5 1/3] KVM: x86: Provide per VM capability for disabling PMU virtualization
2022-02-09 10:33 ` [PATCH v5 1/3] KVM: x86: Provide per VM capability for disabling PMU virtualization Like Xu
@ 2022-02-09 17:30 ` David Dunn
0 siblings, 0 replies; 2+ messages in thread
From: David Dunn @ 2022-02-09 17:30 UTC (permalink / raw)
To: Like Xu
Cc: Paolo Bonzini - Distinguished Engineer (kernel-recipes.org) (KVM
HoF),
kvm, seanjc, Jim Mattson, Vitaly Kuznetsov, Wanpeng Li,
Joerg Roedel, linux-kernel
Thanks Like.
I just sent a new v6 series with these minor merge conflicts resolved.
Dave
On Wed, Feb 9, 2022 at 2:33 AM Like Xu <like.xu.linux@gmail.com> wrote:
>
> cc LKML and full list of KVM reviewers.
>
> On 25/1/2022 2:39 am, Jim Mattson wrote:
> > On Sun, Jan 23, 2022 at 10:45 AM David Dunn <daviddunn@google.com> wrote:
> >>
> >> KVM_CAP_PMU_DISABLE is used to disable PMU virtualization on individual
> >> x86 VMs. PMU configuration must be done prior to creating VCPUs.
> >>
> >> To enable future extension, KVM_CAP_PMU_CAPABILITY reports available
> >> settings via bitmask when queried via check_extension.
> >>
> >> For VMs that have PMU virtualization disabled, usermode will need to
> >> clear CPUID leaf 0xA to notify guests.
> >>
> >> Signed-off-by: David Dunn <daviddunn@google.com>
> >
> > Nit: The two references to CPUID leaf 0xA should be qualified as
> > applying only to Intel VMs.
> >
> > Reviewed-by: Jim Mattson <jmattson@google.com>
> >
>
> Nit: It looks like we already have "#define KVM_CAP_SYS_ATTRIBUTES 209".
>
> Hope it helps a little:
>
> Reviewed-by: Like Xu <likexu@tencent.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-09 17:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220123184541.993212-1-daviddunn@google.com>
[not found] ` <20220123184541.993212-2-daviddunn@google.com>
[not found] ` <CALMp9eSuavLEJ0_jwuOgmSX+Y8iJLsJT0xkGfMZg6B7kGyDmBQ@mail.gmail.com>
2022-02-09 10:33 ` [PATCH v5 1/3] KVM: x86: Provide per VM capability for disabling PMU virtualization Like Xu
2022-02-09 17:30 ` David Dunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®