From: Shuah Khan <shuah@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>,
Shuah Khan <shuahkh@osg.samsung.com>
Cc: valentina.manea.m@gmail.com, yuyang.du@intel.com,
k.opasiak@samsung.com, kstewart@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
juan.zea@qindel.com, Shuah Khan <shuahkh@osg.samsung.com>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] usbip: fix usbip attach to find a port that matches the requested speed
Date: Thu, 30 Nov 2017 07:56:45 -0700 [thread overview]
Message-ID: <09e82933-981b-0cef-3364-baa04aa9a4c3@kernel.org> (raw)
In-Reply-To: <20171130082033.GA18429@kroah.com>
On 11/30/2017 01:20 AM, Greg KH wrote:
> On Wed, Nov 29, 2017 at 03:24:22PM -0700, Shuah Khan wrote:
>> usbip attach fails to find a free port when the device on the first port
>> is a USB_SPEED_SUPER device and non-super speed device is being attached.
>> It keeps checking the first port and returns without a match getting stuck
>> in a loop.
>>
>> Fix it check to find the first port with matching speed.
>>
>> Reported-by: Juan Zea <juan.zea@qindel.com>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>> tools/usb/usbip/libsrc/vhci_driver.c | 14 +++++++++++---
>> 1 file changed, 11 insertions(+), 3 deletions(-)
>
> Does this need to go to the stable trees?
>
Yes it does. I forgot to tag this for stable. There is another
one from Yuyang Du that needs to go into stable. I am just about
to Ack that. These need to go tino 4.13 as well, but looks like
4.13 is all done now. So definitely for 4.14
[PATCH] usbip: Fix USB device hang due to wrong enabling of scatter-gather
thanks,
-- Shuah
prev parent reply other threads:[~2017-11-30 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 22:24 Shuah Khan
2017-11-30 8:20 ` Greg KH
2017-11-30 14:56 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09e82933-981b-0cef-3364-baa04aa9a4c3@kernel.org \
--to=shuah@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=juan.zea@qindel.com \
--cc=k.opasiak@samsung.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuahkh@osg.samsung.com \
--cc=valentina.manea.m@gmail.com \
--cc=yuyang.du@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome