* [PATCH v1] mfd: intel-lpss: Correct names of RESETS register bits
@ 2018-04-24 15:05 Andy Shevchenko
2018-04-25 10:26 ` Mika Westerberg
2018-06-04 5:33 ` Lee Jones
0 siblings, 2 replies; 4+ messages in thread
From: Andy Shevchenko @ 2018-04-24 15:05 UTC (permalink / raw)
To: Lee Jones, linux-kernel, Mika Westerberg; +Cc: Andy Shevchenko
According to documentation the function has 2 bits for reset
while iDMA 64-bit has only one.
Rename it accordingly. Note, there is no functional change since
we always handle them together.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/mfd/intel-lpss.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
index 4bcf117a7ba8..50bffc3382d7 100644
--- a/drivers/mfd/intel-lpss.c
+++ b/drivers/mfd/intel-lpss.c
@@ -40,8 +40,8 @@
/* Offsets from lpss->priv */
#define LPSS_PRIV_RESETS 0x04
-#define LPSS_PRIV_RESETS_FUNC BIT(2)
-#define LPSS_PRIV_RESETS_IDMA 0x3
+#define LPSS_PRIV_RESETS_IDMA BIT(2)
+#define LPSS_PRIV_RESETS_FUNC 0x3
#define LPSS_PRIV_ACTIVELTR 0x10
#define LPSS_PRIV_IDLELTR 0x14
--
2.17.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] mfd: intel-lpss: Correct names of RESETS register bits
2018-04-24 15:05 [PATCH v1] mfd: intel-lpss: Correct names of RESETS register bits Andy Shevchenko
@ 2018-04-25 10:26 ` Mika Westerberg
2018-06-01 7:52 ` Andy Shevchenko
2018-06-04 5:33 ` Lee Jones
1 sibling, 1 reply; 4+ messages in thread
From: Mika Westerberg @ 2018-04-25 10:26 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Lee Jones, linux-kernel
On Tue, Apr 24, 2018 at 06:05:12PM +0300, Andy Shevchenko wrote:
> According to documentation the function has 2 bits for reset
> while iDMA 64-bit has only one.
>
> Rename it accordingly. Note, there is no functional change since
> we always handle them together.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] mfd: intel-lpss: Correct names of RESETS register bits
2018-04-25 10:26 ` Mika Westerberg
@ 2018-06-01 7:52 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2018-06-01 7:52 UTC (permalink / raw)
To: Mika Westerberg; +Cc: Lee Jones, linux-kernel
On Wed, 2018-04-25 at 13:26 +0300, Mika Westerberg wrote:
> On Tue, Apr 24, 2018 at 06:05:12PM +0300, Andy Shevchenko wrote:
> > According to documentation the function has 2 bits for reset
> > while iDMA 64-bit has only one.
> >
> > Rename it accordingly. Note, there is no functional change since
> > we always handle them together.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Thanks, Mika!
Lee, anything about this one? (it's not stable material, though I don't
see it in linux-next)
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] mfd: intel-lpss: Correct names of RESETS register bits
2018-04-24 15:05 [PATCH v1] mfd: intel-lpss: Correct names of RESETS register bits Andy Shevchenko
2018-04-25 10:26 ` Mika Westerberg
@ 2018-06-04 5:33 ` Lee Jones
1 sibling, 0 replies; 4+ messages in thread
From: Lee Jones @ 2018-06-04 5:33 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-kernel, Mika Westerberg
On Tue, 24 Apr 2018, Andy Shevchenko wrote:
> According to documentation the function has 2 bits for reset
> while iDMA 64-bit has only one.
>
> Rename it accordingly. Note, there is no functional change since
> we always handle them together.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mfd/intel-lpss.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-04 5:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 15:05 [PATCH v1] mfd: intel-lpss: Correct names of RESETS register bits Andy Shevchenko
2018-04-25 10:26 ` Mika Westerberg
2018-06-01 7:52 ` Andy Shevchenko
2018-06-04 5:33 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome