From: "Martin Liška" <mliska@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>,
Peter Oberparleiter <oberpar@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gcov: support GCC 12.1 and newer compilers
Date: Mon, 17 Oct 2022 10:02:53 +0200 [thread overview]
Message-ID: <0a04e3ed-aeba-9df9-212e-03232f02da6e@suse.cz> (raw)
In-Reply-To: <20221016174033.d33a998b4c91b7d18b3dc310@linux-foundation.org>
On 10/17/22 02:40, Andrew Morton wrote:
> On Fri, 14 Oct 2022 11:30:51 +0200 Peter Oberparleiter <oberpar@linux.ibm.com> wrote:
>
>> On 13.10.2022 09:40, Martin Liška wrote:
>>> Starting with GCC 12.1, there are 2 significant changes to the .gcda
>>> file format that needs to be supported:
>>>
>>> a) [gcov: Use system IO buffering] (23eb66d1d46a34cb28c4acbdf8a1deb80a7c5a05) changed
>>> that all sizes in the format are in bytes and not in words (4B)
>>> b) [gcov: make profile merging smarter] (72e0c742bd01f8e7e6dcca64042b9ad7e75979de)
>>> add a new checksum to the file header.
>>>
>>> Tested with GCC 7.5, 10.4, 12.2 and the current master.
>>>
>>> Signed-off-by: Martin Liska <mliska@suse.cz>
>>
>> Looks good, thanks! I successfully tested this patch on s390 using GCC
>> 12.2 and 11.2.
>>
>> Tested-by: Peter Oberparleiter <oberpar@linux.ibm.com>
>> Reviewed-by: Peter Oberparleiter <oberpar@linux.ibm.com>
>>
>> Andrew, could you add this patch via your tree?
>
> Sure.
>
> The changelog doesn't tell us what the user-visible effects of this are
> (please, it should do so), but it sounds to me like those effects are
> "gcov is utterly busted".
Hi.
Sorry for the missing user-visible effect. You are correct, the created .gcda
format can't be read by gcov tool since GCC 12.1 release.
Thanks,
Martin
>
> So I'll add a cc:stable to this, so that people can use new gcc
> versions to build older kernels.
next prev parent reply other threads:[~2022-10-17 8:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 7:40 Martin Liška
2022-10-14 9:30 ` Peter Oberparleiter
2022-10-17 0:40 ` Andrew Morton
2022-10-17 8:02 ` Martin Liška [this message]
2022-10-17 11:38 ` David Laight
2022-10-17 12:23 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a04e3ed-aeba-9df9-212e-03232f02da6e@suse.cz \
--to=mliska@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®