mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Martin Liška" <mliska@suse.cz>
To: David Laight <David.Laight@ACULAB.COM>,
	'Andrew Morton' <akpm@linux-foundation.org>,
	Peter Oberparleiter <oberpar@linux.ibm.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gcov: support GCC 12.1 and newer compilers
Date: Mon, 17 Oct 2022 14:23:34 +0200	[thread overview]
Message-ID: <a55cb545-30d8-c035-ec23-4e94c132d7ba@suse.cz> (raw)
In-Reply-To: <9b724e2af2d048c3a7f7f20ae0942ab6@AcuMS.aculab.com>

On 10/17/22 13:38, David Laight wrote:
> From: Andrew Morton
>> Sent: 17 October 2022 01:41
> ..
>> The changelog doesn't tell us what the user-visible effects of this are
>> (please, it should do so), but it sounds to me like those effects are
>> "gcov is utterly busted".
>>
>> So I'll add a cc:stable to this, so that people can use new gcc
>> versions to build older kernels.
> 
> I can't help wondering what happens if you link a binary
> compiled with an old gcc with one build with a new gcc?

It should be fine as the code emits each .gcda file with version that
comes from the compilation phase:

	pos += store_gcov_u32(buffer, pos, info->version);

> 
> This could easily happen with out of tree loadable modules.

Sure.

> Or just linking an old .a file into a userspace binary.
> 
> Now maybe the gcov data isn't used (I've not looked up what
> it is for) but is sounds like something whose format should
> be set in stone?

No, I've doing some changes to the format based on new challenges we face.

Cheers,
Martin

> 
> 	David
> 
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)


      reply	other threads:[~2022-10-17 12:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-13  7:40 Martin Liška
2022-10-14  9:30 ` Peter Oberparleiter
2022-10-17  0:40   ` Andrew Morton
2022-10-17  8:02     ` Martin Liška
2022-10-17 11:38     ` David Laight
2022-10-17 12:23       ` Martin Liška [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a55cb545-30d8-c035-ec23-4e94c132d7ba@suse.cz \
    --to=mliska@suse.cz \
    --cc=David.Laight@ACULAB.COM \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oberpar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®