mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: <quanyang.wang@windriver.com>, <mturquette@baylibre.com>,
	<sboyd@kernel.org>, <michal.simek@xilinx.com>
Cc: <linux-clk@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: zynqmp: enable COMMON_CLK_ZYNQMP for ARCH_ZYNQMP automatically
Date: Tue, 8 Dec 2020 13:42:15 +0100	[thread overview]
Message-ID: <0a0d16a7-0d49-3a89-76a1-141758b138e7@xilinx.com> (raw)
In-Reply-To: <20201208123508.998073-1-quanyang.wang@windriver.com>

Hi,

On 08. 12. 20 13:35, quanyang.wang@windriver.com wrote:
> From: Quanyang Wang <quanyang.wang@windriver.com>
> 
> The Zynqmp Ultrascale clock controller generates clocks for peripherals,
> so we need to enable it when ARCH_ZYNQMP is selected.
> 
> Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
> ---
>  drivers/clk/zynqmp/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/zynqmp/Kconfig b/drivers/clk/zynqmp/Kconfig
> index 17086059be8b..a8aa58bbb790 100644
> --- a/drivers/clk/zynqmp/Kconfig
> +++ b/drivers/clk/zynqmp/Kconfig
> @@ -4,6 +4,7 @@ config COMMON_CLK_ZYNQMP
>  	bool "Support for Xilinx ZynqMP Ultrascale+ clock controllers"
>  	depends on ARCH_ZYNQMP || COMPILE_TEST
>  	depends on ZYNQMP_FIRMWARE
> +	default ARCH_ZYNQMP

This is not right. If you look 2 lines above.

>  	help
>  	  Support for the Zynqmp Ultrascale clock controller.
>  	  It has a dependency on the PMU firmware.
> 

And we were talking about enabling this driver in defconfig. Not via
Kconfig. This fragment was designed in a way that this clock controller
doesn't need to be used. It is our default but if you want to use for
example fixed clock you also can.
This enables space for being able to use for example different firmware.

Thanks,
Michal

  reply	other threads:[~2020-12-08 12:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 12:35 quanyang.wang
2020-12-08 12:42 ` Michal Simek [this message]
2020-12-09  1:14   ` quanyang.wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a0d16a7-0d49-3a89-76a1-141758b138e7@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=quanyang.wang@windriver.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®