From: John Garry <john.garry@huawei.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <jejb@linux.vnet.ibm.com>, <martin.petersen@oracle.com>,
<john.garry2@mail.dcu.ie>, <linuxarm@huawei.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<arnd@arndb.de>, Xiang Chen <chenxiang66@hisilicon.com>
Subject: Re: [PATCH v3 13/23] scsi: hisi_sas: add phy up/down/bcast and channel ISR
Date: Thu, 1 Jun 2017 11:10:27 +0100 [thread overview]
Message-ID: <0a1e06ff-eae4-5ec4-5b9d-c6e29d50b5f1@huawei.com> (raw)
In-Reply-To: <20170601054106.GA4743@infradead.org>
On 01/06/2017 06:41, Christoph Hellwig wrote:
>> > +static int interrupt_init_v3_hw(struct hisi_hba *hisi_hba)
>> > +{
>> > + struct device *dev = hisi_hba->dev;
>> > + struct pci_dev *pdev = hisi_hba->pci_dev;
>> > + int vectors, i, irq, rc;
>> > + int max_msi = HISI_SAS_MSI_COUNT_V3_HW;
>> > + int msi_vectors[HISI_SAS_MSI_COUNT_V3_HW];
>> > +
>> > + if (pdev->msi_enabled)
>> > + pci_disable_msi(pdev);
> How could MSIs be enabled at init time? Even if so you should use
> pci_free_irq_vectors.
Right, I don't think it could, so this can be removed.
>
>> > + for (i = 0; i < vectors; i++)
>> > + msi_vectors[i] = pdev->irq + i;
> You should not need this array, just use pci_irq_vectors().
>
That should be ok.
> .
>
Thanks,
John
next prev parent reply other threads:[~2017-06-01 10:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 14:32 [PATCH v3 00/23] hisi_sas: hip08 support John Garry
2017-05-31 14:32 ` [PATCH v3 01/23] scsi: hisi_sas: fix timeout check in hisi_sas_internal_task_abort() John Garry
2017-05-31 14:32 ` [PATCH v3 02/23] scsi: hisi_sas: define hisi_sas_device.device_id as int John Garry
2017-05-31 14:32 ` [PATCH v3 03/23] scsi: hisi_sas: optimise the usage of hisi_hba.lock John Garry
2017-05-31 14:32 ` [PATCH v3 04/23] scsi: hisi_sas: relocate get_ata_protocol() John Garry
2017-05-31 14:32 ` [PATCH v3 05/23] scsi: hisi_sas: relocate sata_done_v2_hw() John Garry
2017-05-31 14:32 ` [PATCH v3 06/23] scsi: hisi_sas: relocate get_ncq_tag_v2_hw() John Garry
2017-05-31 14:32 ` [PATCH v3 07/23] scsi: hisi_sas: add pci_dev in hisi_hba struct John Garry
2017-05-31 14:33 ` [PATCH v3 08/23] scsi: hisi_sas: create hisi_sas_get_fw_info() John Garry
2017-05-31 14:33 ` [PATCH v3 09/23] scsi: hisi_sas: add skeleton v3 hw driver John Garry
2017-05-31 14:33 ` [PATCH v3 10/23] scsi: hisi_sas: add initialisation for v3 pci-based controller John Garry
2017-05-31 14:33 ` [PATCH v3 11/23] scsi: hisi_sas: add v3 hw init John Garry
2017-05-31 14:33 ` [PATCH v3 12/23] scsi: hisi_sas: add v3 hw PHY init John Garry
2017-05-31 14:33 ` [PATCH v3 13/23] scsi: hisi_sas: add phy up/down/bcast and channel ISR John Garry
2017-06-01 5:41 ` Christoph Hellwig
2017-06-01 10:10 ` John Garry [this message]
2017-05-31 14:33 ` [PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler John Garry
2017-06-01 5:41 ` Christoph Hellwig
2017-06-01 10:36 ` John Garry
2017-06-08 7:34 ` Christoph Hellwig
2017-06-08 12:09 ` John Garry
2017-05-31 14:33 ` [PATCH v3 15/23] scsi: hisi_sas: add v3 code to send SSP frame John Garry
2017-05-31 14:33 ` [PATCH v3 16/23] scsi: hisi_sas: add v3 code to send SMP frame John Garry
2017-05-31 14:33 ` [PATCH v3 17/23] scsi: hisi_sas: add v3 code to send ATA frame John Garry
2017-05-31 14:33 ` [PATCH v3 18/23] scsi: hisi_sas: add v3 code for itct setup and free John Garry
2017-05-31 14:33 ` [PATCH v3 19/23] scsi: hisi_sas: add v3 code to send internal abort command John Garry
2017-05-31 14:33 ` [PATCH v3 20/23] scsi: hisi_sas: add get_wideport_bitmap_v3_hw() John Garry
2017-05-31 14:33 ` [PATCH v3 21/23] scsi: hisi_sas: Add v3 code to support ECC and AXI bus fatal error John Garry
2017-05-31 14:33 ` [PATCH v3 22/23] scsi: hisi_sas: add v3 code to fill some more hw function pointers John Garry
2017-05-31 14:33 ` [PATCH v3 23/23] scsi: hisi_sas: modify internal abort dev flow for v3 hw John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a1e06ff-eae4-5ec4-5b9d-c6e29d50b5f1@huawei.com \
--to=john.garry@huawei.com \
--cc=arnd@arndb.de \
--cc=chenxiang66@hisilicon.com \
--cc=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry2@mail.dcu.ie \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome