From: Steve Longerbeam <slongerbeam@gmail.com>
To: Peter Seiderer <ps.report@gmx.net>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] media: staging/imx: fill vb2_v4l2_buffer sequence entry
Date: Tue, 13 Mar 2018 15:27:12 -0700 [thread overview]
Message-ID: <0a65c663-ee8f-3edb-92ae-426910da9352@gmail.com> (raw)
In-Reply-To: <20180313232449.253c7626@gmx.net>
On 03/13/2018 03:24 PM, Peter Seiderer wrote:
> Hello Steve,
>
> On Tue, 13 Mar 2018 15:03:07 -0700, Steve Longerbeam <slongerbeam@gmail.com> wrote:
>
>> Hi Peter,
>>
>> Thanks for the patch.
>>
>> This needs to be done in imx-ic-prpencvf.c as well, see
>> prp_vb2_buf_done().
> Ahh, I see...., would you prefer an follow up patch or
> an v2 patch doing the changes on mx-media-csi.c and
> imx-ic-prpencvf.c at once?
Hi Peter, a v2 patch would be fine.
Steve
> On 03/13/2018 01:00 PM, Peter Seiderer wrote:
>>> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>>> ---
>>> drivers/staging/media/imx/imx-media-csi.c | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
>>> index 5a195f80a24d..3a6a645b9dce 100644
>>> --- a/drivers/staging/media/imx/imx-media-csi.c
>>> +++ b/drivers/staging/media/imx/imx-media-csi.c
>>> @@ -111,6 +111,7 @@ struct csi_priv {
>>> struct v4l2_ctrl_handler ctrl_hdlr;
>>>
>>> int stream_count; /* streaming counter */
>>> + __u32 frame_sequence; /* frame sequence counter */
>>> bool last_eof; /* waiting for last EOF at stream off */
>>> bool nfb4eof; /* NFB4EOF encountered during streaming */
>>> struct completion last_eof_comp;
>>> @@ -234,8 +235,11 @@ static void csi_vb2_buf_done(struct csi_priv *priv)
>>> struct vb2_buffer *vb;
>>> dma_addr_t phys;
>>>
>>> + priv->frame_sequence++;
>>> +
>>> done = priv->active_vb2_buf[priv->ipu_buf_num];
>>> if (done) {
>>> + done->vbuf.sequence = priv->frame_sequence;
>>> vb = &done->vbuf.vb2_buf;
>>> vb->timestamp = ktime_get_ns();
>>> vb2_buffer_done(vb, priv->nfb4eof ?
>>> @@ -543,6 +547,7 @@ static int csi_idmac_start(struct csi_priv *priv)
>>>
>>> /* init EOF completion waitq */
>>> init_completion(&priv->last_eof_comp);
>>> + priv->frame_sequence = 0;
>>> priv->last_eof = false;
>>> priv->nfb4eof = false;
>>>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-03-13 22:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 20:00 Peter Seiderer
2018-03-13 22:03 ` Steve Longerbeam
2018-03-13 22:24 ` Peter Seiderer
2018-03-13 22:27 ` Steve Longerbeam [this message]
2018-03-14 5:36 ` Greg Kroah-Hartman
2018-03-14 8:31 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a65c663-ee8f-3edb-92ae-426910da9352@gmail.com \
--to=slongerbeam@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=ps.report@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®