From: Andreas Larsson <andreas@gaisler.com>
To: Nathan Chancellor <nathan@kernel.org>, Rosen Penev <rosenp@gmail.com>
Cc: Kjetil Oftedal <oftedal@gmail.com>,
sparclinux@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:CLANG/LLVM BUILD SUPPORT:Keyword:b(?i:clang|llvm)b"
<llvm@lists.linux.dev>
Subject: Re: [PATCH] sparc64: Define p4d_page() instead of stubbing it to NULL
Date: Wed, 7 Oct 2026 13:08:46 +0200 [thread overview]
Message-ID: <0a72b324-9909-4c46-819a-93389bb1f04f@gaisler.com> (raw)
In-Reply-To: <20261007094141.GA1527675@ax162>
On 2026-10-07 11:41, Nathan Chancellor wrote:
> On Tue, Oct 06, 2026 at 05:00:30PM -0700, Rosen Penev wrote:
>> LLM suggests as an alternative:
>>
>> /* sparc64 has no p4d leaf mappings, so this is never called */
>> static inline struct page *p4d_page(p4d_t p4d)
>> {
>> return NULL;
>> }
>>
>> Not sure how to proceed.
>
> That seems like a more reasonable fix to me, as it is still obvious this
> is not supported while hiding the NULL value from clang's frontend that
> emits the warning. It could be worth a comment that it is an inline
> function and not a macro to avoid the warning but I guess that is up to
> the sparc maintainers.
I agree, including comment.
Regarding "ptdump and KASAN" in the commit message, while true, both
these are locked behind KASAN which is not supported by sparc64.
Cheers,
Andreas
prev parent reply other threads:[~2026-10-07 11:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 20:39 Rosen Penev
2026-10-06 7:59 ` Kjetil Oftedal
2026-10-06 8:31 ` Nathan Chancellor
2026-10-07 0:00 ` Rosen Penev
2026-10-07 9:41 ` Nathan Chancellor
2026-10-07 11:08 ` Andreas Larsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a72b324-9909-4c46-819a-93389bb1f04f@gaisler.com \
--to=andreas@gaisler.com \
--cc=davem@davemloft.net \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=oftedal@gmail.com \
--cc=rosenp@gmail.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®