Re: [PATCH RESEND v2 03/11] dt-bindings: arm: stm32: Modify STM32MP15x Phytec board items types

[Christophe Parant <c.parant@phytec.fr>]

Hi Rob,

Le jeudi 11 décembre 2025 à 10:00 -0600, Rob Herring a écrit :
> On Wed, Dec 10, 2025 at 11:16:03AM +0100, Christophe Parant wrote:
> > As Phytec manages different SoM configurations with different
> > STM32MP15
> > SoC versions, modify the phyBOARD and SoM compatible items to
> > "enum"
> > instead of "const".
> 
> Change to enum when you add a 2nd string. I don't follow why you
> would 
Ok, I thought it was possible to use enum here (kind of information
that others board versions are available but not upstream yet).
As I saw examples in the same file where enum is used with only one
string. For example: "seeed,stm32mp157c-odyssey" or "st,stm32mp235f-
dk".
But I could change to const if this is an issue, no problem.

> do that either. You have more than 1 SoM for stm32mp157?
Yes we have several versions. Here, we would also like to add our
"phycore-stm32mp1-4" which is equipped with the "F" version of
stm32mp157: "stm32mp157f" (which is
another board device tree).
But didn't want to add it now in this patch series.
We also have "phycore-stm32mp1-6" which is equipped with "stm32mp153a".
The idea was to keep this Description section for the "st,stm32mp157"
(const items) and would need another section for the "st,stm32mp13a".
> 
> > The description concerns PHYTEC SoM equipped with STM32MP157
> > ("st,stm32mp157" is "const").
> > Also add comments in front of the enum items to be able to identify
> > the
> > compatible string with the phyBOARD/phyCORE names.
> > 
> > Signed-off-by: Christophe Parant <c.parant@phytec.fr>
> > ---
> >  Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 8 +++++--
> > -
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> > b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> > index 408532504a24..fbd3d364c1f7 100644
> > --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> > +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> > @@ -182,10 +182,12 @@ properties:
> >            - const: seeed,stm32mp157c-odyssey-som
> >            - const: st,stm32mp157
> >  
> > -      - description: Phytec STM32MP1 SoM based Boards
> > +      - description: Phytec STM32MP157 SoM based Boards
> >          items:
> > -          - const: phytec,phycore-stm32mp1-3
> > -          - const: phytec,phycore-stm32mp157c-som
> > +          - enum:
> > +              - phytec,phycore-stm32mp1-3 # phyBOARD-Sargas with
> > phyCORE-STM32MP157C SoM
> > +          - enum:
> > +              - phytec,phycore-stm32mp157c-som # phyCORE-
> > STM32MP157C SoM
> >            - const: st,stm32mp157
> >  
> >        - description: Ultratronik STM32MP1 SBC based Boards
> > -- 
> > 2.34.1
> >