From: Christophe Parant <c.parant@phytec.fr>
To: "robh@kernel.org" <robh@kernel.org>
Cc: "alexandre.torgue@foss.st.com" <alexandre.torgue@foss.st.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"upstream@lists.phytec.de" <upstream@lists.phytec.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>
Subject: Re: [PATCH RESEND v2 03/11] dt-bindings: arm: stm32: Modify STM32MP15x Phytec board items types
Date: Thu, 8 Jan 2026 16:31:31 +0000 [thread overview]
Message-ID: <15d8e394bc7fd00f464b007a074acc5b1b6101dd.camel@phytec.fr> (raw)
In-Reply-To: <0ad7413a5252633b2a820db1cf2a10f7d658f6c6.camel@phytec.fr>
Hi Rob,
Did you see my answer below ?
Thanks for you time.
Best Regards,
Christophe
Le vendredi 19 décembre 2025 à 10:28 +0100, Christophe Parant a écrit :
> Hi Rob,
>
> Le jeudi 11 décembre 2025 à 10:00 -0600, Rob Herring a écrit :
> > On Wed, Dec 10, 2025 at 11:16:03AM +0100, Christophe Parant wrote:
> > > As Phytec manages different SoM configurations with different
> > > STM32MP15
> > > SoC versions, modify the phyBOARD and SoM compatible items to
> > > "enum"
> > > instead of "const".
> >
> > Change to enum when you add a 2nd string. I don't follow why you
> > would
> Ok, I thought it was possible to use enum here (kind of information
> that others board versions are available but not upstream yet).
> As I saw examples in the same file where enum is used with only one
> string. For example: "seeed,stm32mp157c-odyssey" or "st,stm32mp235f-
> dk".
> But I could change to const if this is an issue, no problem.
>
> > do that either. You have more than 1 SoM for stm32mp157?
> Yes we have several versions. Here, we would also like to add our
> "phycore-stm32mp1-4" which is equipped with the "F" version of
> stm32mp157: "stm32mp157f" (which is
> another board device tree).
> But didn't want to add it now in this patch series.
> We also have "phycore-stm32mp1-6" which is equipped with
> "stm32mp153a".
> The idea was to keep this Description section for the "st,stm32mp157"
> (const items) and would need another section for the "st,stm32mp13a".
> >
> > > The description concerns PHYTEC SoM equipped with STM32MP157
> > > ("st,stm32mp157" is "const").
> > > Also add comments in front of the enum items to be able to
> > > identify
> > > the
> > > compatible string with the phyBOARD/phyCORE names.
> > >
> > > Signed-off-by: Christophe Parant <c.parant@phytec.fr>
> > > ---
> > > Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 8
> > > +++++--
> > > -
> > > 1 file changed, 5 insertions(+), 3 deletions(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> > > b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> > > index 408532504a24..fbd3d364c1f7 100644
> > > --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> > > @@ -182,10 +182,12 @@ properties:
> > > - const: seeed,stm32mp157c-odyssey-som
> > > - const: st,stm32mp157
> > >
> > > - - description: Phytec STM32MP1 SoM based Boards
> > > + - description: Phytec STM32MP157 SoM based Boards
> > > items:
> > > - - const: phytec,phycore-stm32mp1-3
> > > - - const: phytec,phycore-stm32mp157c-som
> > > + - enum:
> > > + - phytec,phycore-stm32mp1-3 # phyBOARD-Sargas with
> > > phyCORE-STM32MP157C SoM
> > > + - enum:
> > > + - phytec,phycore-stm32mp157c-som # phyCORE-
> > > STM32MP157C SoM
> > > - const: st,stm32mp157
> > >
> > > - description: Ultratronik STM32MP1 SBC based Boards
> > > --
> > > 2.34.1
> > >
next prev parent reply other threads:[~2026-01-08 16:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 10:16 [PATCH RESEND v2 00/11] Rework and fix STM32MP15x PHYTEC dts Christophe Parant
2025-12-10 10:16 ` [PATCH RESEND v2 01/11] ARM: dts: stm32: phycore-stm32mp15: Rename device tree files Christophe Parant
2025-12-10 10:16 ` [PATCH RESEND v2 02/11] ARM: dts: stm32: phyboard-sargas: Introduce SoM device tree Christophe Parant
2025-12-10 10:16 ` [PATCH RESEND v2 03/11] dt-bindings: arm: stm32: Modify STM32MP15x Phytec board items types Christophe Parant
2025-12-11 16:00 ` Rob Herring
2025-12-19 9:28 ` Christophe Parant
2026-01-08 16:31 ` Christophe Parant [this message]
2025-12-10 10:16 ` [PATCH RESEND v2 04/11] ARM: dts: stm32: Add new pinmux groups for phyboard-sargas and phycore Christophe Parant
2025-12-10 10:16 ` [PATCH RESEND v2 05/11] ARM: dts: stm32: phyboard-sargas: Fix uart4 and sai2 pinctrl Christophe Parant
2025-12-10 10:16 ` [PATCH RESEND v2 06/11] ARM: dts: stm32: phycore-stm32mp15: qspi: Fix memory map and pinctrl Christophe Parant
2025-12-10 10:16 ` [PATCH RESEND v2 07/11] ARM: dts: stm32: phycore-stm32mp15: Add dummy memory-node Christophe Parant
2025-12-10 10:16 ` [PATCH RESEND v2 08/11] ARM: dts: stm32: phyboard-sargas: Move aliases from dts to dtsi Christophe Parant
2025-12-10 10:16 ` [PATCH RESEND v2 09/11] ARM: dts: stm32: phycore-stm32mp15: Disable optional SoM peripherals Christophe Parant
2025-12-10 10:16 ` [PATCH RESEND v2 10/11] ARM: dts: stm32: phyboard-sargas and phycore: Fix coding style issues Christophe Parant
2025-12-10 10:16 ` [PATCH RESEND v2 11/11] ARM: dts: stm32: phyboard-sargas and phycore: Add optional interfaces Christophe Parant
2026-03-06 9:23 ` [PATCH RESEND v2 00/11] Rework and fix STM32MP15x PHYTEC dts Alexandre TORGUE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15d8e394bc7fd00f464b007a074acc5b1b6101dd.camel@phytec.fr \
--to=c.parant@phytec.fr \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh@kernel.org \
--cc=upstream@lists.phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®