* [PATCH] drm/msm/dsi: Add check for devm_kstrdup()
@ 2025-02-19 4:07 Haoxiang Li
2025-02-19 12:45 ` Dmitry Baryshkov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Haoxiang Li @ 2025-02-19 4:07 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, marijn.suijten,
airlied, simona, jonathan, quic_jesszhan, konradybcio,
haoxiang_li2024
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, stable
Add check for the return value of devm_kstrdup() in
dsi_host_parse_dt() to catch potential exception.
Fixes: 958d8d99ccb3 ("drm/msm/dsi: parse vsync source from device tree")
Cc: stable@vger.kernel.org
Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
index 007311c21fda..6dd1e10d8014 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -1827,8 +1827,15 @@ static int dsi_host_parse_dt(struct msm_dsi_host *msm_host)
__func__, ret);
goto err;
}
- if (!ret)
+ if (!ret) {
msm_dsi->te_source = devm_kstrdup(dev, te_source, GFP_KERNEL);
+ if (!msm_dsi->te_source) {
+ DRM_DEV_ERROR(dev, "%s: failed to allocate te_source\n",
+ __func__);
+ ret = -ENOMEM;
+ goto err;
+ }
+ }
ret = 0;
if (of_property_present(np, "syscon-sfpb")) {
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/msm/dsi: Add check for devm_kstrdup()
2025-02-19 4:07 [PATCH] drm/msm/dsi: Add check for devm_kstrdup() Haoxiang Li
@ 2025-02-19 12:45 ` Dmitry Baryshkov
2025-02-19 20:09 ` Abhinav Kumar
2025-02-27 4:37 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-02-19 12:45 UTC (permalink / raw)
To: Haoxiang Li
Cc: robdclark, quic_abhinavk, sean, marijn.suijten, airlied, simona,
jonathan, quic_jesszhan, konradybcio, linux-arm-msm, dri-devel,
freedreno, linux-kernel, stable
On Wed, Feb 19, 2025 at 12:07:12PM +0800, Haoxiang Li wrote:
> Add check for the return value of devm_kstrdup() in
> dsi_host_parse_dt() to catch potential exception.
>
> Fixes: 958d8d99ccb3 ("drm/msm/dsi: parse vsync source from device tree")
> Cc: stable@vger.kernel.org
> Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
> ---
> drivers/gpu/drm/msm/dsi/dsi_host.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/msm/dsi: Add check for devm_kstrdup()
2025-02-19 4:07 [PATCH] drm/msm/dsi: Add check for devm_kstrdup() Haoxiang Li
2025-02-19 12:45 ` Dmitry Baryshkov
@ 2025-02-19 20:09 ` Abhinav Kumar
2025-02-27 4:37 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Abhinav Kumar @ 2025-02-19 20:09 UTC (permalink / raw)
To: Haoxiang Li, robdclark, dmitry.baryshkov, sean, marijn.suijten,
airlied, simona, jonathan, quic_jesszhan, konradybcio
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, stable
On 2/18/2025 8:07 PM, Haoxiang Li wrote:
> Add check for the return value of devm_kstrdup() in
> dsi_host_parse_dt() to catch potential exception.
>
> Fixes: 958d8d99ccb3 ("drm/msm/dsi: parse vsync source from device tree")
> Cc: stable@vger.kernel.org
> Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
> ---
> drivers/gpu/drm/msm/dsi/dsi_host.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/msm/dsi: Add check for devm_kstrdup()
2025-02-19 4:07 [PATCH] drm/msm/dsi: Add check for devm_kstrdup() Haoxiang Li
2025-02-19 12:45 ` Dmitry Baryshkov
2025-02-19 20:09 ` Abhinav Kumar
@ 2025-02-27 4:37 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-02-27 4:37 UTC (permalink / raw)
To: robdclark, quic_abhinavk, sean, marijn.suijten, airlied, simona,
jonathan, quic_jesszhan, konradybcio, Haoxiang Li
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, stable
On Wed, 19 Feb 2025 12:07:12 +0800, Haoxiang Li wrote:
> Add check for the return value of devm_kstrdup() in
> dsi_host_parse_dt() to catch potential exception.
>
>
Applied, thanks!
[1/1] drm/msm/dsi: Add check for devm_kstrdup()
https://gitlab.freedesktop.org/lumag/msm/-/commit/52b3f0e118b1
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-02-27 4:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-19 4:07 [PATCH] drm/msm/dsi: Add check for devm_kstrdup() Haoxiang Li
2025-02-19 12:45 ` Dmitry Baryshkov
2025-02-19 20:09 ` Abhinav Kumar
2025-02-27 4:37 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®