From: Paolo Bonzini <pbonzini@redhat.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Wanpeng Li <kernellwp@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 2/2] KVM: VMX: Add Force Emulation Prefix for "emulate the next instruction"
Date: Tue, 27 Mar 2018 09:25:05 +0200 [thread overview]
Message-ID: <0ad9fff9-6ebb-2d63-5c9f-b9aba7d619ac@redhat.com> (raw)
In-Reply-To: <20180327051840.GF16974@char.us.oracle.com>
On 27/03/2018 07:18, Konrad Rzeszutek Wilk wrote:
>> I think a global module is enough for testing.
> If so, perhaps have it wrapped with #ifdef DEBUG?
>
> No need to put code gadgets that won't be utilized 99% of time.
It is going to be used a lot in testing, actually. There are quite a
few emulate.c bugfixes that are hard to test (see for example the
syscall eflags.tf bug that can currently be tested only on Intel) and
having something like this can only improve our coverage.
#ifdef DEBUG is almost always a bad idea, and though I agree that the
commit messages can be improved, I think the module parameter is the way
to go.
Wanpeng, can you also add it to svm.c?
Thanks,
Paolo
next prev parent reply other threads:[~2018-03-27 7:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 2:12 [PATCH 0/2] " Wanpeng Li
2018-03-27 2:12 ` [PATCH 1/2] KVM: VMX: Introduce handle_ud() Wanpeng Li
2018-03-27 4:38 ` Konrad Rzeszutek Wilk
2018-03-27 2:12 ` [PATCH 2/2] KVM: VMX: Add Force Emulation Prefix for "emulate the next instruction" Wanpeng Li
2018-03-27 4:40 ` Konrad Rzeszutek Wilk
2018-03-27 4:55 ` Konrad Rzeszutek Wilk
2018-03-27 5:03 ` Wanpeng Li
2018-03-27 5:18 ` Konrad Rzeszutek Wilk
2018-03-27 7:25 ` Paolo Bonzini [this message]
2018-03-27 7:29 ` Wanpeng Li
2018-03-27 5:09 ` Wanpeng Li
2018-03-27 7:52 Liran Alon
2018-03-27 8:19 ` Paolo Bonzini
2018-03-27 9:09 ` Wanpeng Li
2018-03-27 8:26 Liran Alon
2018-03-27 9:05 ` Nikita Leshenko
2018-03-27 9:15 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ad9fff9-6ebb-2d63-5c9f-b9aba7d619ac@redhat.com \
--to=pbonzini@redhat.com \
--cc=andrew.cooper3@citrix.com \
--cc=kernellwp@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®