mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Liran Alon <liran.alon@oracle.com>
To: <pbonzini@redhat.com>
Cc: <kernellwp@gmail.com>, <rkrcmar@redhat.com>,
	<andrew.cooper3@citrix.com>, <linux-kernel@vger.kernel.org>,
	<kvm@vger.kernel.org>
Subject: Re: [PATCH 2/2] KVM: VMX: Add Force Emulation Prefix for "emulate the next instruction"
Date: Tue, 27 Mar 2018 01:26:51 -0700 (PDT)	[thread overview]
Message-ID: <d34c1d3c-324e-4645-9d48-09c94212aa5e@default> (raw)


----- pbonzini@redhat.com wrote:

> On 27/03/2018 09:52, Liran Alon wrote:
> > In addition, I think this module parameter should be in kvm module
> > (not kvm_intel) and you should add similar logic to kvm_amd module
> (SVM)
> 
> If you can move handle_ud to x86.c, then it makes sense to have the
> module parameter in the kvm module.  I haven't checked.

I don't see a reason why you couldn't do that.

> 
> Otherwise you would have to EXPORT_SYMBOL_GPL the variable; in the

This is what I did for enable_vmware_backdoor module parameter.
I think this is what should be done in this case as-well.

> end
> it's just a debugging tool, so it'd be simpler to just add it
> separately
> to kvm_intel and kvm_amd.

I agree it's just a debugging tool. But no reason for it to be used differently
when running tests on Intel CPU vs. AMD CPU.
I think the effort to fix this is low.

> 
> Paolo

             reply	other threads:[~2018-03-27  8:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-27  8:26 Liran Alon [this message]
2018-03-27  9:05 ` Nikita Leshenko
2018-03-27  9:15   ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2018-03-27  7:52 Liran Alon
2018-03-27  8:19 ` Paolo Bonzini
2018-03-27  9:09 ` Wanpeng Li
2018-03-27  2:12 [PATCH 0/2] " Wanpeng Li
2018-03-27  2:12 ` [PATCH 2/2] " Wanpeng Li
2018-03-27  4:40   ` Konrad Rzeszutek Wilk
2018-03-27  4:55     ` Konrad Rzeszutek Wilk
2018-03-27  5:03       ` Wanpeng Li
2018-03-27  5:18         ` Konrad Rzeszutek Wilk
2018-03-27  7:25           ` Paolo Bonzini
2018-03-27  7:29             ` Wanpeng Li
2018-03-27  5:09     ` Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d34c1d3c-324e-4645-9d48-09c94212aa5e@default \
    --to=liran.alon@oracle.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®