From: Guenter Roeck <linux@roeck-us.net>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v4 1/3] hwmon: (pmbus/core) improve handling of write protected regulators
Date: Mon, 2 Dec 2024 22:06:26 -0800 [thread overview]
Message-ID: <0afdcb04-5ada-4bd0-b1e1-c28663f952f0@roeck-us.net> (raw)
In-Reply-To: <20241202-tps25990-v4-1-bb50a99e0a03@baylibre.com>
On Mon, Dec 02, 2024 at 11:28:00AM +0100, Jerome Brunet wrote:
> Writing PMBus protected registers does succeed from the smbus perspective,
> even if the write is ignored by the device and a communication fault is
> raised. This fault will silently be caught and cleared by pmbus irq if one
> has been registered.
>
> This means that the regulator call may return succeed although the
> operation was ignored.
>
> With this change, the operation which are not supported will be properly
> flagged as such and the regulator framework won't even try to execute them.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Applied.
Thanks,
Guenter
next prev parent reply other threads:[~2024-12-03 6:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 10:27 [PATCH v4 0/3] hwmon: pmbus: add tps25990 efuse support Jerome Brunet
2024-12-02 10:28 ` [PATCH v4 1/3] hwmon: (pmbus/core) improve handling of write protected regulators Jerome Brunet
2024-12-03 6:06 ` Guenter Roeck [this message]
2024-12-02 10:28 ` [PATCH v4 2/3] hwmon: (pmbus/core) add wp module param Jerome Brunet
2024-12-03 6:06 ` Guenter Roeck
2024-12-02 10:28 ` [PATCH v4 3/3] hwmon: (pmbus/tps25990): add initial support Jerome Brunet
2024-12-03 6:11 ` Guenter Roeck
2024-12-05 19:50 ` Kees Bakker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0afdcb04-5ada-4bd0-b1e1-c28663f952f0@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Delphine_CC_Chiu@wiwynn.com \
--cc=corbet@lwn.net \
--cc=jbrunet@baylibre.com \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®