From: Kees Bakker <kees@ijzerbout.nl>
To: Jerome Brunet <jbrunet@baylibre.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Corbet <corbet@lwn.net>,
Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
Cc: linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
Vaishnav Achath <vaishnav.a@ti.com>
Subject: Re: [PATCH v4 3/3] hwmon: (pmbus/tps25990): add initial support
Date: Thu, 5 Dec 2024 20:50:14 +0100 [thread overview]
Message-ID: <72486280-1852-41a2-ae17-2288d7fedd54@ijzerbout.nl> (raw)
In-Reply-To: <20241202-tps25990-v4-3-bb50a99e0a03@baylibre.com>
Op 02-12-2024 om 11:28 schreef Jerome Brunet:
> Add initial support for the Texas Instruments TPS25990 eFuse.
> This adds the basic PMBUS telemetry support for the device.
>
> Tested-by: Vaishnav Achath <vaishnav.a@ti.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> Documentation/hwmon/index.rst | 1 +
> Documentation/hwmon/tps25990.rst | 148 +++++++++++++
> MAINTAINERS | 2 +
> drivers/hwmon/pmbus/Kconfig | 17 ++
> drivers/hwmon/pmbus/Makefile | 1 +
> drivers/hwmon/pmbus/tps25990.c | 437 +++++++++++++++++++++++++++++++++++++++
> 6 files changed, 606 insertions(+)
>
> [...]
> diff --git a/drivers/hwmon/pmbus/tps25990.c b/drivers/hwmon/pmbus/tps25990.c
> new file mode 100644
> index 0000000000000000000000000000000000000000..0a267014c88997fca5e83b2ec974a0d521808512
> [...]
> + case PMBUS_VIRT_READ_IIN_MAX:
> + return TPS25990_READ_IIN_PEAK;
> + ret = pmbus_read_word_data(client, page, phase,
> + TPS25990_READ_IIN_PEAK);
> + break;
> [...]
Is the return intended? Or some left-over debug code?
--
Kees
prev parent reply other threads:[~2024-12-05 19:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 10:27 [PATCH v4 0/3] hwmon: pmbus: add tps25990 efuse support Jerome Brunet
2024-12-02 10:28 ` [PATCH v4 1/3] hwmon: (pmbus/core) improve handling of write protected regulators Jerome Brunet
2024-12-03 6:06 ` Guenter Roeck
2024-12-02 10:28 ` [PATCH v4 2/3] hwmon: (pmbus/core) add wp module param Jerome Brunet
2024-12-03 6:06 ` Guenter Roeck
2024-12-02 10:28 ` [PATCH v4 3/3] hwmon: (pmbus/tps25990): add initial support Jerome Brunet
2024-12-03 6:11 ` Guenter Roeck
2024-12-05 19:50 ` Kees Bakker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72486280-1852-41a2-ae17-2288d7fedd54@ijzerbout.nl \
--to=kees@ijzerbout.nl \
--cc=Delphine_CC_Chiu@Wiwynn.com \
--cc=corbet@lwn.net \
--cc=jbrunet@baylibre.com \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=vaishnav.a@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®